Page MenuHomePhabricator

Provide temporary accounts banner for legacy Vector
Open, Stalled, HighPublicBUG REPORT

Description

When implementing the banner for IP masked users in T330510 we intentionally limited the design to the Vector 2022 skin and Minerva skin, as implementation was technically challenging for the other skins.

Given Wikimedia sites do not present Timeless, Monobook, Vector, CologneBlue, Vector([1] or Modern to anonymous users and we lacked clear designs for these skins (which use absolute positioning) we descoped this for now.

3rd party sites that use these skins and support anonymous editing would potentially need updates to these skins (and mocks).

Developer notes

Skins can enable the banner by adding "tempUserBanner": true so the options in their skin definition like this example in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/930849
For skins which do not rely on absolute positioning incorporating the banner will be easy, but skins that do use absolute positioning will need some changes to support IP masking. This banner by default will not display correctly in the skin so will require changes in the skin to be incorporated.

For example here is how the banner looks in Vector currently without changes:

Screenshot 2023-06-16 at 10.41.06 AM.png (641×1 px, 124 KB)

[1] We recognize several sites have Vector as the default skin, but we are not clear on the timeline for IP masking/desktop improvements and whether this needs to be fixed beforehand.

Event Timeline

Given Wikimedia sites do not present Timeless, Monobook, Vector, CologneBlue, Vector([1] or Modern to anonymous users and we lacked clear designs for these skins (which use absolute positioning) we descoped this for now.

I believe the only one we really need to add support for is legacy Vector, because quite a few wikis still support this as the default skin for anonymous users. This would be a blocker for deploying to e.g. dewiki.

Should we repurpose this task to be just about legacy Vector, or file a new task to track that?

As for timeline: the sooner the better? Two of the four pilot wikis are defaulting to legacy Vector for anonymous users. We could try to convince those wikis to switch to new Vector as the default, but it might be better to just implement the support for legacy Vector, if it is not a large amount of work.

We can repurpose this for legacy Vector, but just to set expectations - this is likely going to require a new design for the banner or a big architectural change to Vector. I would prefer the former if possible!

We can repurpose this for legacy Vector, but just to set expectations - this is likely going to require a new design for the banner or a big architectural change to Vector. I would prefer the former if possible!

Sounds like new design for legacy Vector would be the way to go, then. @Madalina @Niharika, could you please talk with @ovasileva to coordinate the timing for this, given that legacy Vector is used on some of the proposed pilot wikis?

kostajh renamed this task from Implement the IP masking banner in other skins (The IP masking banner doesn't show for non-Wikimedia default skins (including Vector)) to Provide temporary accounts banner for legacy Vector.Mar 12 2024, 1:33 PM
kostajh changed the task status from Open to Stalled.Mar 12 2024, 1:40 PM

We discussed in temp accounts weekly check-in today. What we'll do for now: remove wikis with legacy Vector from the pilot wikis. Ideally, by the time we are rolling forward to other wikis, we'll be farther along with deploying Vector 2022 to wikis still using legacy Vector. If not, we can revisit this task.

@Jdlrobson it would be helpful to get a rough idea of scope of work for implementing a banner for legacy Vector