See the parent task for more information. This task is for adding the pulsating dot and showing a popup when it is clicked, with the help message and link. The “don’t show this again” checkbox is left for a separate subtask (T340644).
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Goal | Manuel | T285156 [GOAL] Add termbox language code mul to reduce redundancy in Wikidata Labels and Aliases | ||
| Open | Manuel | T312097 [EPIC] MUL - Default values for labels and aliases | |||
| Resolved | Release | None | T329661 [Milestone] v0.4 of the `mul` language code (test.wikidata.org) | ||
| Resolved | Manuel | T316769 [STORY] MUL - Add link to help page about “multiple languages” in the desktop termbox in editing mode | |||
| Resolved | guergana.tzatchkova | T340643 Add pulsating dot with help popup to `mul` in desktop termbox |
Event Timeline
Comment Actions
Change 933678 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):
[mediawiki/extensions/Wikibase@master] Add pulsating dot for extra info on mul language row
Comment Actions
Change 935133 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):
[wikibase/termbox@master] Add messages for popup for multiple languages
Comment Actions
Change 935133 abandoned by Guergana Tzatchkova:
[wikibase/termbox@master] Add messages for popup for multiple languages
Reason:
messages already added in I9b8b40b9dc114341c4d830280b5698fd45b7c450 as part of the "wikibase.view.ControllerViewFactory" module
Comment Actions
Change 933678 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add pulsating dot for extra info on mul language row
Comment Actions
It's working! \o/
One small thing: The position of the dot seems to be off a bit on my system (see screenshot). Would this be easy to fix?
Comment Actions
One more thing: Every time I click on "All entered languages" it shows me an additional dot. 😅
Comment Actions
That should have been fixed yesterday (when Don’t add multiple pulsating dots) was merged) – is it still happening for you?
Comment Actions
Yes, it's still happening for me on Test Wikidata. It is not happening on Beta. Should the dot even be active on Test?
while this made for a somewhat pleasing visual effect
I should read your patch descriptions more often 😂
Comment Actions
Oh yes, I forgot this is also testable on Test Wikidata. Yeah, it should be fixed there next week.
Why should the dot not be on Beta?
Comment Actions
I meant on Test (changed it but your answer was too quick xD). I was not sure if we were still testing the soft rollout on Test or not. But thinking about it, it actually makes sense to have the dot during the soft rollout. So nevermind.
Comment Actions
Oh no, I am only realizing now, that the dot is also visible in viewing mode. It should only be visible in editing mode. Can we still fix this?
Comment Actions
Yes, but let’s do it in a separate task IMHO: T342550: Only show pulsating dot in edit mode
This one can probably be closed?
Comment Actions
This one can probably be closed?
Fixing the dot position seems to be still open:
The dot belongs to the label of the input box ("multiple languages") and not to the input box itself. @Sarai-WMDE can help you, when in doubt.
Comment Actions
This one can probably be closed?
Fixing the dot position seems to be still open:
I don’t have access to that file.
On my end the dot also wraps around, which makes it hard for me to debug the issue Sarai pointed out:
Comment Actions
A separate task for it would probably be best. Right now it’s not even clear to me what the problem is.