Page MenuHomePhabricator
Create Task
Maniphest T341202

Unable to edit an article on mobile (JavaScript error)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Reported by @Mcgiwer on Discord

Steps to replicate the issue (include links if applicable):

What happens?:

  • Unable to save the edit
  • Bottom of screen transparent popup that says https://en.m.wikipedia.org/wiki/Category:Free_ERP_software#/editor/all at line 781: Uncaught TypeError: Cannot read properties of undefined (reading 'firstNodes')

image.png (2×1 px, 888 KB)

What should have happened instead?:

  • Normal editing

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

  • Codesearch suggests this is either in Extension:Cite or Extension:VisualEditor
  • I wasn't able to reproduce it on Desktop. May be browser-specific or some other variable.
  • Not sure if it is only above page or all pages. Will ask @Mcgiwer

Details

SubjectRepoBranchLines +/-
Revert "Add tag when reference added to the page"mediawiki/extensions/VisualEditormaster+0 -28
EditCheck: Account for getNodeGroup returning undefinedmediawiki/extensions/VisualEditormaster+2 -1
Revert "Add tag when reference added to the page"mediawiki/extensions/VisualEditorwmf/1.41.0-wmf.16+0 -28
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasehasharT340244 1.41.0-wmf.16 deployment blockers
 ResolvedBUG REPORTmatmarexT341202 Unable to edit an article on mobile (JavaScript error)

Event Timeline

Novem_Linguae created this task.Jul 6 2023, 11:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 6 2023, 11:16 AM
Novem_Linguae renamed this task from Unable to edit articles to Unable to edit an article on mobile (JavaScript error).Jul 6 2023, 11:17 AM
matmarex triaged this task as Unbreak Now! priority.Jul 6 2023, 11:27 AM
matmarex added a parent task: T340244: 1.41.0-wmf.16 deployment blockers.
Novem_Linguae updated the task description. (Show Details)Jul 6 2023, 11:30 AM
matmarex subscribed.Jul 6 2023, 11:35 AM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/935088

gerritbot added a comment.Jul 6 2023, 11:35 AM

Change 935853 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Revert "Add tag when reference added to the page"

https://gerrit.wikimedia.org/r/935853

gerritbot added a project: Patch-For-Review.Jul 6 2023, 11:35 AM
matmarex mentioned this in T325713: Introduce a change tag to identify edits that include a reference.Jul 6 2023, 11:36 AM
gerritbot added a comment.Jul 6 2023, 11:36 AM

Change 935854 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.16] Revert "Add tag when reference added to the page"

https://gerrit.wikimedia.org/r/935854

matmarex added a comment.EditedJul 6 2023, 11:38 AM

I can reproduce the error.

TheresNoTime subscribed.Jul 6 2023, 11:43 AM
matmarex added a comment.Jul 6 2023, 11:45 AM

Big spike in error logging: https://logstash.wikimedia.org/goto/9629d8d78b282d89da37edeee01d3b02

image.png (527×2 px, 69 KB)

All of these errors are the same issue (different browsers generate different messages):

  • TypeError: target.getSurface().getModel().getDocument().getInternalList().getNodeGroup(...) is undefined
  • TypeError: Cannot read properties of undefined (reading 'firstNodes')
  • TypeError: undefined is not an object (evaluating 'target.getSurface().getModel().getDocument().getInternalList().getNodeGroup('mwReference/').firstNodes')
  • TypeError: target.getSurface(...).getModel(...).getDocument(...).getInternalList(...).getNodeGroup(...) is undefined
  • TypeError: Cannot read property 'firstNodes' of undefined
Novem_Linguae added a project: Regression.Jul 6 2023, 11:47 AM
Novem_Linguae removed a project: Cite.
gerritbot added a comment.Jul 6 2023, 12:08 PM

Change 935854 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.41.0-wmf.16] Revert "Add tag when reference added to the page"

https://gerrit.wikimedia.org/r/935854

Stashbot added a comment.Jul 6 2023, 12:08 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-06T12:08:33Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:935854|Revert "Add tag when reference added to the page" (T341202)]]

Stashbot added a comment.Jul 6 2023, 12:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-06T12:21:03Z] <samtar@deploy1002> matmarex and samtar: Backport for [[gerrit:935854|Revert "Add tag when reference added to the page" (T341202)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Stashbot added a comment.Jul 6 2023, 12:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-07-06T12:32:38Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:935854|Revert "Add tag when reference added to the page" (T341202)]] (duration: 24m 04s)

gerritbot added a comment.Jul 6 2023, 12:49 PM

Change 936028 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] EditCheck: Account for getNodeGroup returning undefined

https://gerrit.wikimedia.org/r/936028

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 6 2023, 1:00 PM
gerritbot added a comment.Jul 6 2023, 1:04 PM

Change 935853 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Revert "Add tag when reference added to the page"

https://gerrit.wikimedia.org/r/935853

gerritbot added a comment.Jul 6 2023, 1:18 PM

Change 936028 abandoned by Esanders:

[mediawiki/extensions/VisualEditor@master] EditCheck: Account for getNodeGroup returning undefined

Reason:

Squashed into I9dc5a77045ea5f15c90cf84a15815e13dffd5739

https://gerrit.wikimedia.org/r/936028

gerritbot added a comment.Jul 6 2023, 1:19 PM

Change 935855 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Revert "Revert "Add tag when reference added to the page""

https://gerrit.wikimedia.org/r/935855

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 6 2023, 2:00 PM
matmarex closed this task as Resolved.Jul 6 2023, 3:56 PM
matmarex claimed this task.
hashar mentioned this in T340244: 1.41.0-wmf.16 deployment blockers.Jul 6 2023, 4:32 PM
• ppelberg subscribed.Jul 6 2023, 5:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL