Page MenuHomePhabricator
Create Task
Maniphest T341669

Allow for multiple confd instances in puppet
Closed, ResolvedPublic
Actions

Description

I would like our confd puppet code to support multiple confd instances per node.

For T329826: Kubernetes v1.23 use PKI for service-account signing (instead of cergen) I wanted to add a confd with the k8s etcd cluster as backend but realized that confd is already instantiated for the global etcd (by ferm).

Details

SubjectRepoBranchLines +/-
confd: Only notify the current instanceoperations/puppetproduction+3 -9
confd: -prefix from confd cli to confd::file instancesoperations/puppetproduction+74 -64
confd: Move -prefix from confd cli to confd::file instancesoperations/puppetproduction+2 -10
confd: Use the unit name as syslog identifieroperations/puppetproduction+1 -0
confd::instance: support prefix in non-main instancesoperations/puppetproduction+10 -2
conftool::state: use confd::default_instanceoperations/puppetproduction+1 -1
confd: allow running multiple instancesoperations/puppetproduction+177 -104
Customize query in gerrit

Related Objects
Search...

Event Timeline

JMeybohm created this task.Jul 12 2023, 10:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2023, 10:11 AM
JMeybohm renamed this task from Allow for multiple confd instances in in pupper to Allow for multiple confd instances in pupper.Jul 12 2023, 10:11 AM
gerritbot added a comment.Jul 13 2023, 5:40 AM

Change 937573 had a related patch set uploaded (by Giuseppe Lavagetto; author: Giuseppe Lavagetto):

[operations/puppet@production] confd: allow running multiple instances

https://gerrit.wikimedia.org/r/937573

gerritbot added a project: Patch-For-Review.Jul 13 2023, 5:40 AM
Stashbot added a comment.Jul 21 2023, 8:47 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-21T08:47:10Z] <jayme> disabling puppet in C:cumin - T341669

Stashbot added a comment.Jul 21 2023, 8:47 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-21T08:47:33Z] <jayme> disabling puppet in C:confd - T341669

gerritbot added a comment.Jul 21 2023, 8:50 AM

Change 937573 merged by JMeybohm:

[operations/puppet@production] confd: allow running multiple instances

https://gerrit.wikimedia.org/r/937573

gerritbot added a comment.Jul 21 2023, 9:01 AM

Change 940325 had a related patch set uploaded (by JMeybohm; author: Giuseppe Lavagetto):

[operations/puppet@production] conftool::state: use confd::default_instance

https://gerrit.wikimedia.org/r/940325

gerritbot added a comment.Jul 21 2023, 9:04 AM

Change 940325 merged by JMeybohm:

[operations/puppet@production] conftool::state: use confd::default_instance

https://gerrit.wikimedia.org/r/940325

Stashbot added a comment.Jul 21 2023, 9:09 AM

Mentioned in SAL (#wikimedia-operations) [2023-07-21T09:09:49Z] <jayme> enable puppet on C:confd - T341669

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 9:10 AM
gerritbot added a comment.Jul 21 2023, 10:04 AM

Change 940329 had a related patch set uploaded (by JMeybohm; author: Giuseppe Lavagetto):

[operations/puppet@production] confd::instance: support prefix in non-main instances

https://gerrit.wikimedia.org/r/940329

gerritbot added a project: Patch-For-Review.Jul 21 2023, 10:04 AM
gerritbot added a comment.Jul 21 2023, 10:19 AM

Change 940329 merged by JMeybohm:

[operations/puppet@production] confd::instance: support prefix in non-main instances

https://gerrit.wikimedia.org/r/940329

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 10:30 AM
gerritbot added a comment.Jul 21 2023, 2:23 PM

Change 940362 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/puppet@production] confd: Use the unit name as syslog identifier

https://gerrit.wikimedia.org/r/940362

gerritbot added a project: Patch-For-Review.Jul 21 2023, 2:23 PM
gerritbot added a comment.Jul 21 2023, 2:30 PM

Change 940362 merged by JMeybohm:

[operations/puppet@production] confd: Use the unit name as syslog identifier

https://gerrit.wikimedia.org/r/940362

JMeybohm closed this task as Resolved.Jul 21 2023, 2:59 PM
JMeybohm claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jul 21 2023, 3:10 PM
Kappakayala renamed this task from Allow for multiple confd instances in pupper to Allow for multiple confd instances in puppet.Jul 28 2023, 5:44 PM
JMeybohm reopened this task as Open.Aug 7 2023, 6:13 PM
In T147204#5546368, @Joe wrote:

I had to roll back confd in reprepro and on puppetmaster1001 because I found a regression (or, a change in behaviour): the prefix key in the confd files isn't respected in confd 0.16.0 if a prefix is declared on the command line.

This makes sense - the previous behaviour was somewhat confusing to reason about, but this means we have to convert all of our confd files to a format compatible with both versions.

My line of thinking is as follows:

  • Remove -prefix from the command line
  • Add it back as default_prefix in confd::file, and prepend it to any prefix
  • Leave everything else as-is

However, this stresses the necessity to check carefully all of our confd templates. I will do so and report the results on this ticket.

We did introduce -prefix to the cli again in this task...

JMeybohm moved this task from Incoming 🐫 to Doing 😎 on the serviceops board.Aug 21 2023, 2:25 PM
gerritbot added a comment.Aug 21 2023, 4:54 PM

Change 951124 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/puppet@production] confd: Move -prefix from confd cli to confd::file instances

https://gerrit.wikimedia.org/r/951124

gerritbot added a project: Patch-For-Review.Aug 21 2023, 4:54 PM
gerritbot added a comment.Aug 31 2023, 12:23 PM

Change 954007 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] confd: -prefix from confd cli to confd::file instances

https://gerrit.wikimedia.org/r/954007

gerritbot added a comment.Sep 4 2023, 7:55 AM

Change 951124 abandoned by JMeybohm:

[operations/puppet@production] confd: Move -prefix from confd cli to confd::file instances

Reason:

Ibcad8a27e88451d4ae8f0114bf9aaf602bc107cd

https://gerrit.wikimedia.org/r/951124

gerritbot added a comment.Sep 4 2023, 9:50 AM

Change 954007 merged by Jbond:

[operations/puppet@production] confd: -prefix from confd cli to confd::file instances

https://gerrit.wikimedia.org/r/954007

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2023, 10:10 AM
gerritbot added a comment.Sep 4 2023, 10:14 AM

Change 954610 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] confd: Only notify the current instance

https://gerrit.wikimedia.org/r/954610

gerritbot added a project: Patch-For-Review.Sep 4 2023, 10:14 AM
gerritbot added a comment.Sep 4 2023, 10:21 AM

Change 954610 merged by Jbond:

[operations/puppet@production] confd: Only notify the current instance

https://gerrit.wikimedia.org/r/954610

Maintenance_bot removed a project: Patch-For-Review.Sep 4 2023, 10:31 AM
JMeybohm closed this task as Resolved.Sep 4 2023, 10:32 AM
JMeybohm added a subscriber: jbond.

Thanks to @jbond's refactor this is now resolved (again).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL