Special:Preferences tab/section navigation hints are missing
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Func
	Jul 13 2023, 5:07 PM

Description

Steps to replicate the issue (include links if applicable):

Visit Special:Preferences
Use the tab key to navigate to the first preference tab (desktop) or section (mobile)

What happens?:

No navigation hint is displayed before tabbing into the tabs (desktop) or sections (mobile)

What should have happened instead?:

A hint message should be displayed before tabbing into the first tab (desktop) or section (mobile)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Code changed in 4aa9c929102f4e162c242d647b74523f85363b22 mistakenly rewrote tabIndex to sectionIndex
Code added in 4aa9c929102f4e162c242d647b74523f85363b22, but didn't add the message to json file

Details

	Subject	Repo	Branch	Lines +/-
	Special:Preferences fix broken navigation hints	mediawiki/core	master	+21 -8

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T349553 [EPIC] Moderator Tools Maintenance Work
Resolved		• Samwalton9-WMF	T338040 [Epic] Q1 FY 2023-24 Moderator Tools Maintenance Work
Resolved	BUG REPORT	jsn.sherman	T341816 Special:Preferences tab/section navigation hints are missing

Event Timeline

Func created this task.Jul 13 2023, 5:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 13 2023, 5:07 PM

Aklapper mentioned this in T321330: Fix anchored links in new mobile preferences design.Aug 6 2023, 9:49 PM

Scardenasmolinar added a parent task: T338040: [Epic] Q1 FY 2023-24 Moderator Tools Maintenance Work.Aug 9 2023, 6:48 PM

Scardenasmolinar subscribed.

jsn.sherman added a project: Moderator-Tools-Team (Kanban).Aug 14 2023, 2:51 PM

jsn.sherman claimed this task.Aug 25 2023, 6:51 PM

jsn.sherman moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 952494 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/core@master] Special:Preferences fix broken navigation hints

https://gerrit.wikimedia.org/r/952494

gerritbot added a project: Patch-For-Review.Aug 25 2023, 7:39 PM

jsn.sherman moved this task from In Progress to Code review on the Moderator-Tools-Team (Kanban) board.Aug 25 2023, 7:40 PM

jsn.sherman renamed this task from Message prefs-sections-navigation-hint is missing to Special:Preferences tab/section navigation hints are missing.Aug 25 2023, 7:49 PM

jsn.sherman changed the task status from Open to In Progress.

jsn.sherman triaged this task as High priority.

jsn.sherman updated the task description. (Show Details)

Scardenasmolinar moved this task from Code review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Aug 26 2023, 2:51 AM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/68d9f5b10c/w