Page MenuHomePhabricator

Requesting access to releasers-wikibase for darthmon_wmde
Closed, DeclinedPublicRequest

Description

Requestor provided information and prerequisites

This section is to be completed by the individual requesting access.

  • Wikitech username: Monica Pinedo (WMDE)
  • Email address: monica.pinedo@wikimedia.de
  • SSH public key (must be a separate key from Wikimedia cloud SSH access): ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIExSTDAxRmRvMSo4Bsx1cA0Tske9hEKa8qCltQDpV7pE monicapinedo@wmde-102496
  • Requested group membership: releasers-wikibase
  • Reason for access: As part of the Wikibase Suite Team at WMDE will be preparing and ultimately publishing new tarball release packages of Wikibase software on releases.wikimedia.org
  • Name of approving party (manager for WMF/WMDE staff): I am the Engineering Manager of the team making the Wikibase Suite releases. WMF approval not needed.
  • Ensure you have signed the L3 Wikimedia Server Access Responsibilities document:
  • Please coordinate obtaining a comment of approval on this task from the approving party.

SRE Clinic Duty Confirmation Checklist for Access Requests

This checklist should be used on all access requests to ensure that all steps are covered, including expansion to existing access. Please double check the step has been completed before checking it off.

This section is to be confirmed and completed by a member of the SRE team.

  • - User has signed the L3 Acknowledgement of Wikimedia Server Access Responsibilities Document.
  • - User has a valid NDA on file with WMF legal. (All WMF Staff/Contractor hiring are covered by NDA. Other users can be validated via the NDA tracking sheet)
  • - User has provided the following: wikitech username, email address, and full reasoning for access (including what commands and/or tasks they expect to perform)
  • - User has provided a public SSH key. This ssh key pair should only be used for WMF cluster access, and not shared with any other service (this includes not sharing with WMCS access, no shared keys.)
  • - The provided SSH key has been confirmed out of band and is verified not being used in WMCS.
  • - access request (or expansion) has sign off of WMF sponsor/manager (sponsor for volunteers, manager for wmf staff)
  • - access request (or expansion) has sign off of group approver indicated by the approval field in data.yaml

For additional details regarding access request requirements, please see https://wikitech.wikimedia.org/wiki/Requesting_shell_access

Event Timeline

@KFrancis hello, we'd need verification that this user has an NDA on file, would you mind checking? Thank you in advance!

@fgiunchedi not sure if that is good enough but I was able to locate T222788 about Mónica's NDA.

@KFrancis hello, we'd need verification that this user has an NDA on file, would you mind checking? Thank you in advance!

Mónica is in the tracking sheet (https://docs.google.com/spreadsheets/d/1xQNx5s2yErvayCMzvk9VkIA2ZihFXSBEhT5Z5ziCsi4/edit?pli=1#gid=1925010937) and I can confirm that she has an existing NDA.

Hi all, I am confirming there in an NDA on file. Please proceed with the access request. Thanks!

Thank you @MoritzMuehlenhoff @KFrancis !

@darthmon_wmde the following actions are missing (see task description for details)

  • Sign L3
  • Verification of your ssh keys out of band, the easiest would be to public the public key on your wiki user page

thank you !

@WMDE-leszek we're seeking approvals as you are listed as an approval party for releasers-wikibase group, thank you !

@darthmon_wmde hello, you mentioned you'll be managing the wikibase releases, as such I take it you'll be added to approval in https://github.com/wikimedia/operations-puppet/blob/production/modules/admin/data/data.yaml#L224 ? Does the list need any further update? thank you!

hi! firs of all thanks a lot for the quick reaction to this!

L3 signed on Jan 25 2021, 9:44 PM.

Screenshot from 2023-08-04 10-33-26.png (574×852 px, 79 KB)

@darthmon_wmde hello, you mentioned you'll be managing the wikibase releases, as such I take it you'll be added to approval in https://github.com/wikimedia/operations-puppet/blob/production/modules/admin/data/data.yaml#L224 ? Does the list need any further update? thank you!

not for the moment, thanks for checking

  • Verification of your ssh keys out of band, the easiest would be to public the public key on your wiki user page

done

L3 signed on Jan 25 2021, 9:44 PM.

Screenshot from 2023-08-04 10-33-26.png (574×852 px, 79 KB)

thank you! my bad for not checking via username and only first name!

  • Verification of your ssh keys out of band, the easiest would be to public the public key on your wiki user page

done

I am failing to find the update, on which wiki / user did you make the update? I checked the following:

apologies, @fgiunchedi , I may have misunderstood. I added it to https://wikitech.wikimedia.org/wiki/Special:Preferences#mw-prefsection-openstack. Is that alright? Did you mean to add it to the front user page?

apologies, @fgiunchedi , I may have misunderstood. I added it to https://wikitech.wikimedia.org/wiki/Special:Preferences#mw-prefsection-openstack. Is that alright? Did you mean to add it to the front user page?

Yes I meant to the user front page (wikitech preferences ssh keys are for cloud/wmcs, not production), for example here is fine: https://www.mediawiki.org/wiki/User:Monica_Pinedo_Bajo_(WMDE)

apologies, @fgiunchedi , I may have misunderstood. I added it to https://wikitech.wikimedia.org/wiki/Special:Preferences#mw-prefsection-openstack. Is that alright? Did you mean to add it to the front user page?

Yes I meant to the user front page (wikitech preferences ssh keys are for cloud/wmcs, not production), for example here is fine: https://www.mediawiki.org/wiki/User:Monica_Pinedo_Bajo_(WMDE)

Done!

thanks for the clarification and apologies again for the mishap :)

Change 946632 had a related patch set uploaded (by Eevans; author: Eevans):

[operations/puppet@production] admin: add darthmon to releasers-wikibase

https://gerrit.wikimedia.org/r/946632

Change 946632 merged by Eevans:

[operations/puppet@production] admin: add darthmon to releasers-wikibase

https://gerrit.wikimedia.org/r/946632

Hi @darthmon_wmde, this should now be complete.

I'll close the issue, but don't hesitate to reopen if you have any issues!

@darthmon_wmde this seems to be the same key used to access Wikimedia Cloud Services. Could you please generate a separate SSH key for accessing Wikimedia production and post the pubkey here and to your user page?

@darthmon_wmde this seems to be the same key used to access Wikimedia Cloud Services. Could you please generate a separate SSH key for accessing Wikimedia production and post the pubkey here and to your user page?

this sounds weird since I created this key just before posting it here and I have not used it otherwise

I happily create another one in any case:

ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM5JYD88f9NiE6Kg0G7lIVdsZUC2Sp8gDif/kgnkuq/j monicapinedo@wmde-102496

@darthmon_wmde this seems to be the same key used to access Wikimedia Cloud Services. Could you please generate a separate SSH key for accessing Wikimedia production and post the pubkey here and to your user page?

this sounds weird since I created this key just before posting it here and I have not used it otherwise

You know, I thought it was weird to me as well; I'd have sworn I checked prior to adding it, but afterward/now the new key shows up in both places...

eevans@mwmaint1002:~$ cross-validate-accounts 
darthmon uses the same SSH key(s) in WMCS and production:
  {'AAAAC3NzaC1lZDI1NTE5AAAAIAKqqF3EjMr1y5oM+5qfjBrQq/BhRsoHLA4DGZYtWKaE'}
eevans@mwmaint1002:~$

I happily create another one in any case:

ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM5JYD88f9NiE6Kg0G7lIVdsZUC2Sp8gDif/kgnkuq/j monicapinedo@wmde-102496

I'll add your new key; Thanks!

Change 948164 had a related patch set uploaded (by Eevans; author: Eevans):

[operations/puppet@production] admin: new ssh key for user darthmon

https://gerrit.wikimedia.org/r/948164

Change 948164 merged by Eevans:

[operations/puppet@production] admin: new ssh key for user darthmon

https://gerrit.wikimedia.org/r/948164

Ok, this is done; Thanks!

eevans@mwmaint1002:~$ cross-validate-accounts 
eevans@mwmaint1002:~$
Clement_Goubert subscribed.

This new key has been added to WMCS apparently:

darthmon uses the same SSH key(s) in WMCS and production:
  {'AAAAC3NzaC1lZDI1NTE5AAAAIM5JYD88f9NiE6Kg0G7lIVdsZUC2Sp8gDif/kgnkuq/j'}

Change 951064 had a related patch set uploaded (by Jbond; author: jbond):

[operations/puppet@production] admin: drop ssh key for dartmon

https://gerrit.wikimedia.org/r/951064

Change 951064 merged by Jbond:

[operations/puppet@production] admin: drop ssh key for dartmon

https://gerrit.wikimedia.org/r/951064

@darthmon_wmde I have removed this ssh key from the production ssh config. please update this task with a new ssh key that is not used in the WMCS environment. please also update the status back to open once the new key has been added

jbond triaged this task as Medium priority.Aug 21 2023, 10:14 AM
jbond changed the task status from Open to Stalled.Aug 21 2023, 1:56 PM

This task has been stalled since August. As far as I can tell we are still waiting for a new SSH key. Any updates on that?

hi folks. @darthmon_wmde is currently off. I'll remind her of a missing ssh key once she's back in January. Stalling until then so it does not show up in your boards confusingly etc. (ah no, it is already stalled phabricator just reminded me)

herron subscribed.

Hello! Grooming the backlog today. Given that we've been in a holding pattern on this for some time I'll temporarily close as 'invalid' (since we're needing user input in order to proceed) with the understanding that it'll be reopened by the requestor when ready to proceed. Thanks!

I am very sorry - this ticket got out of my sight and I completely forgot about it. Could we pick it up anew, please?

I just added my new public ssh key: ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIExSTDAxRmRvMSo4Bsx1cA0Tske9hEKa8qCltQDpV7pE monicapinedo@wmde-102496

Can you update the key present on your mediawiki page as well ? Thanks

jcrespo changed the task status from Open to Stalled.Mar 25 2024, 10:42 AM
jcrespo subscribed.

Hola, @darthmon_wmde ! A ver si conseguimos cerrar esto de una vez por todas :-D. Si podrías actualizar la clave con tu cuenta con una edición en tu página de usuario de MediaWiki (pero no en la opción de openstack de wikitech!, que es cuando salta el problema de reuso de claves).

Stalling this until then.

BCornwall subscribed.

Closing this until the original poster can get this done.

BCornwall changed the task status from Invalid to Declined.Tue, Apr 23, 8:11 PM