Page MenuHomePhabricator
Create Task
Maniphest T343081

Template:Imagestacks on Commons broken
Closed, ResolvedPublicBUG REPORT
Actions

Description

Template:Imagestack on Commons is used to scroll through sets of images. (Typically these are medical images like MRI scans.)

So the desired behavior is, that only one image is shown, and one can click or scroll to the one before or after.

Now it is broken, and all images are shown below each other. This was probably caused by changes in the Javascript or CSS.

This screenshot suggests, the problem is missing Javascript.
(Other users have confirmed the problem. So this is not just in my browser.)

I do not know since when the problem exists, but I know that it still worked on June 21.

Related Objects

Event Timeline

Watchduck created this task.Jul 29 2023, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2023, 9:16 PM
Watchduck updated the task description. (Show Details)Jul 29 2023, 9:16 PM
Watchduck updated the task description. (Show Details)
Watchduck updated the task description. (Show Details)Aug 12 2023, 12:15 PM
Watchduck updated the task description. (Show Details)
Watchduck updated the task description. (Show Details)Aug 12 2023, 12:17 PM
Aklapper added a comment.Aug 12 2023, 2:28 PM

Hi, please see https://www.mediawiki.org/wiki/Help:Locating_broken_scripts how you can debug the problem and provide more verbose information.

Aklapper renamed this task from Imagestacks on Commons broken to Template:Imagestacks on Commons broken.Aug 12 2023, 2:28 PM
TheDJ added subscribers: AntiCompositeNumber, TheDJ.Dec 23 2023, 2:18 PM

This is because the HTML for the images changed.

And Interface admin on Commons can fix this by changing https://commons.wikimedia.org/wiki/MediaWiki:Gadget-ImageStack.js#L-34 from .ImageStackUnits div.center to figure

stjn closed this task as Resolved.Mar 27 2024, 2:00 AM
stjn claimed this task.
stjn subscribed.

Changed by MusikAnimal after my request.

Watchduck added a comment.Mar 27 2024, 9:15 AM

So the fix was adapting a find in jQuery, after the HTML had been changed. Could someone also link that HTML change? I suppose there must be some protocol to check depending JS before changing the HTML. It would be useful to figure out what went wrong.

stjn added a comment.Mar 27 2024, 9:28 AM

See https://www.mediawiki.org/wiki/Figure_migration / T314318: Disable wgParserEnableLegacyMediaDOM on all wikis

TheDJ added a comment.Mar 27 2024, 11:14 AM
In T343081#9664580, @Watchduck wrote: It would be useful to figure out what went wrong.

Nothing went wrong. The change was communicated, but it is very difficult to know all the things that depend on this exact structure. Stuff falls through the cracks, especially with Commons not having a ton of js/css capable editors any longer.

Theres also about 6 gadgets still depending on jquery ui which has been deprecated for like 6 years now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL