Translation of some key namespaces ("Module:", others?) missing from 1.41.0-wmf.20, breaking any hewiki page that uses that
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Hyphen
	Aug 2 2023, 6:19 PM

Description

Steps to replicate the issue (include links if applicable):
open any page in hewiki uses modules.
For example:
https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%93%D7%9C%D7%A4%D7%A7_%D7%99%D7%99%D7%A2%D7%95%D7%A5?uselang=en&safemode=1

What happens?:
I think that the "Module:" synonym on HeWp (which was "יחידה:") canceled accidentally and breaks the entire site.

What should have happened instead?:
put it back to normal. return the synonym – "יחידה:".

Other information (browser name/version, screenshots, etc.):
urgent! the wiki full of those

Details

Subject	Repo	Branch	Lines +/-
LocalisationCache: Load only core data if possible (v2)	mediawiki/core	master	+141 -23
LocalisationCache: Add tests for preload behavior	mediawiki/core	master	+159 -19
LocalisationCache: Correctly merge preload data	mediawiki/core	master	+4 -2
Revert "LocalisationCache: Load only core data if possible"	mediawiki/core	wmf/1.41.0-wmf.20	+22 -140
Revert "LocalisationCache: Load only core data if possible"	mediawiki/core	master	+22 -140

Customize query in gerrit

Related Objects

Mentioned In: T343343: TypeError: Argument 1 passed to MediaWiki\Extension\DiscussionTools\LanguageData::convertDateFormat() must be of the type string, null given
T340832: [STORY] MUL - While reading, make Wikibase label fallbacks or the `mul` language code default clearly visible
T342418: Speed up Language creation
T340248: 1.41.0-wmf.20 deployment blockers
Mentioned Here: T336211: Find a solution for handling duplicate access keys and access keys of hidden elements (watchlist, login, contributions, search, edit)
T342418: Speed up Language creation

Event Timeline

Hyphen created this task.Aug 2 2023, 6:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 2 2023, 6:20 PM

Hyphen triaged this task as Unbreak Now! priority.Aug 2 2023, 6:21 PM

IKhitron awarded a token.Aug 2 2023, 6:23 PM

dancy added a parent task: T340248: 1.41.0-wmf.20 deployment blockers.Aug 2 2023, 6:25 PM

dancy mentioned this in T340248: 1.41.0-wmf.20 deployment blockers.

dancy subscribed.

There are a couple of namespaces broken. I can see 828, 829 and 2600, for example.

The 1.41.0-wmf.20 train rolled forward to group1 around 18:16:38 UTC. I'm rolling the train back now.

The Scribunto namespace names file hasn't been changed for three months for any language, so it's not that.

Indeed, there was only one, i18n-only change to Scribunto since wmf.19.

Jdforrester-WMF renamed this task from "Module:" synonym on HeWp canceled and breaks the entire site. to Translation of some key namespaces ("Module:", others?) missing from 1.41.0-wmf.20, breaking any hewiki page that uses that.Aug 2 2023, 6:33 PM

Jdforrester-WMF added projects: Scribunto, MediaWiki-General.

Well. It's OK now, as you can see in my link above, and the red alerts are gone.

Train rollback completed at 18:32:01 UTC.

It definitely looks like the cause.

Change 944853 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[mediawiki/core@master] Revert "LocalisationCache: Load only core data if possible"

https://gerrit.wikimedia.org/r/944853

gerritbot added a project: Patch-For-Review.Aug 2 2023, 7:10 PM

Nikerabbit subscribed.Aug 2 2023, 7:17 PM

Change 944853 merged by jenkins-bot:

[mediawiki/core@master] Revert "LocalisationCache: Load only core data if possible"

https://gerrit.wikimedia.org/r/944853

Change 944854 had a related patch set uploaded (by Ahmon Dancy; author: Ahmon Dancy):

[mediawiki/core@wmf/1.41.0-wmf.20] Revert "LocalisationCache: Load only core data if possible"

https://gerrit.wikimedia.org/r/944854

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 2 2023, 8:00 PM

Hyphen changed the subtype of this task from "Bug Report" to "Production Error".Aug 2 2023, 8:27 PM

Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptAug 2 2023, 8:27 PM

Change 944854 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.20] Revert "LocalisationCache: Load only core data if possible"

https://gerrit.wikimedia.org/r/944854

Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:46:38Z] <dancy@deploy1002> Started scap: Backport for [[gerrit:944854|Revert "LocalisationCache: Load only core data if possible" (T342418 T343375)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:48:13Z] <dancy@deploy1002> dancy: Backport for [[gerrit:944854|Revert "LocalisationCache: Load only core data if possible" (T342418 T343375)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Mentioned in SAL (#wikimedia-operations) [2023-08-02T20:55:26Z] <dancy@deploy1002> Finished scap: Backport for [[gerrit:944854|Revert "LocalisationCache: Load only core data if possible" (T342418 T343375)]] (duration: 08m 47s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 2 2023, 9:00 PM

@Hyphen , @IKhitron I reverted the suspected commit and rolled forward to group1 again. The test page looks good to me. Can you confirm?

Looks fine to me.

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2023, 9:10 PM

Great! Removing this ticket as a train blocker.

dancy removed a parent task: T340248: 1.41.0-wmf.20 deployment blockers.Aug 2 2023, 9:11 PM

Winston_Sung subscribed.Aug 3 2023, 3:09 AM

Michael subscribed.Aug 3 2023, 8:49 AM

Michael mentioned this in T340832: [STORY] MUL - While reading, make Wikibase label fallbacks or the `mul` language code default clearly visible.Aug 3 2023, 8:53 AM

matmarex mentioned this in T343343: TypeError: Argument 1 passed to MediaWiki\Extension\DiscussionTools\LanguageData::convertDateFormat() must be of the type string, null given.Aug 3 2023, 11:14 AM

Lucas_Werkmeister_WMDE subscribed.Aug 3 2023, 11:25 AM

matmarex subscribed.Aug 3 2023, 1:19 PM

tstarling subscribed.Aug 3 2023, 11:49 PM

Change 945763 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] LocalisationCache: Add tests for preload behavior

https://gerrit.wikimedia.org/r/945763

Change 945764 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] LocalisationCache: Correctly merge preload data

https://gerrit.wikimedia.org/r/945764

Change 945765 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/core@master] LocalisationCache: Load only core data if possible (v2)

https://gerrit.wikimedia.org/r/945765

neriah subscribed.Aug 6 2023, 5:28 PM

Change 945763 merged by jenkins-bot:

[mediawiki/core@master] LocalisationCache: Add tests for preload behavior

https://gerrit.wikimedia.org/r/945763

Change 945764 merged by jenkins-bot:

[mediawiki/core@master] LocalisationCache: Correctly merge preload data

https://gerrit.wikimedia.org/r/945764

Change 945765 merged by jenkins-bot:

[mediawiki/core@master] LocalisationCache: Load only core data if possible (v2)

https://gerrit.wikimedia.org/r/945765

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.22; 2023-08-15); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 8 2023, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 8 2023, 12:11 PM

With the new changes merged, the Module namespace is still working correctly on beta hewiki (and beta dewiki) as far as I can tell. (There’s one minor issue I noticed, which is that Alt+Shift+E focuses the “edit source” link but doesn’t activate it, i.e. the accesskey isn’t quite working – but that’s true in the main namespace and on beta enwiki too, so I suspect it’s a general Beta issue.)

I think we can tentatively close this as resolved.

In T343375#9077539, @Lucas_Werkmeister_WMDE wrote:

(There’s one minor issue I noticed, which is that Alt+Shift+E focuses the “edit source” link but doesn’t activate it, i.e. the accesskey isn’t quite working – but that’s true in the main namespace and on beta enwiki too, so I suspect it’s a general Beta issue.)

This appears to be T336211 btw.