Page MenuHomePhabricator
Create Task
Maniphest T343471

Gerrit does not send email when a new patchset is created using the web interface
Open, Needs TriagePublic
Actions

Description

Gerrit does not send email when a new patchset is created using the web interface. (I was annoyed about occasionally missing notifications for a long time, and I think I finally realized what's causing it.) It sends email only when it is pushed using Git commands.

For example, on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ConfirmEdit/+/937981, I did not get any emails about patchset 2 being created (by editing patchset 1 in the web interface), but I got an email about the subsequent comment.

Potentially related upstream issue:

Related Objects

Event Timeline

matmarex created this task.Aug 3 2023, 4:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2023, 4:10 PM
matmarex awarded a token.Oct 25 2023, 6:36 PM
hashar added a project: Upstream.Jan 11 2024, 3:29 PM
hashar subscribed.

I have upgraded Gerrit from 3.5.x to 3.6.8 this morning and "maybe" that might have fixed it.

I haven't investigated the root cause of the issue nor whether it has ever worked but that definitely sounds like an upstream bug.

hashar updated the task description. (Show Details)Jan 11 2024, 3:32 PM
matmarex added a comment.Jan 11 2024, 5:18 PM

I've actually read the release notes when you announced the upgrade looking for a fix to this, and did not see anything relevant. But I will pay attention and report back if I notice that this works now (or still doesn't).

matmarex added a comment.Jan 17 2024, 6:56 PM

Not fixed :(

Paladox subscribed.Wed, Apr 17, 12:38 PM

Does this still not work (gerrit is now on 3.8)?

Jdforrester-WMF subscribed.Wed, Apr 17, 12:45 PM
In T343471#9722276, @Paladox wrote:

Does this still not work (gerrit is now on 3.8)?

AIUI the web editor in gerrit is broken since we moved to 3.8, so I don't think we can test yet.

Paladox added a comment.Wed, Apr 17, 12:47 PM
In T343471#9722290, @Jdforrester-WMF wrote:
In T343471#9722276, @Paladox wrote:

Does this still not work (gerrit is now on 3.8)?

AIUI the web editor in gerrit is broken since we moved to 3.8, so I don't think we can test yet.

If you refresh your cache that should fix it. CodeMirror plugin no longer uses Polymer. There's an issue with cache. The editor works for me.

hashar added a comment.Wed, Apr 17, 1:17 PM

The web editor breakage got filed as T362545: Inline editing of files no longer works in Gerrit and that is cache related.

matmarex added a comment.Wed, Apr 17, 8:23 PM

Just tried it, still not working – I edited https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/774399, I have my preferences set up to receive emails about my own actions, but I did not get an email about the new patchset.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL