Page MenuHomePhabricator
Create Task
Maniphest T344521

Remove unused SerializedValueContainer "unified" feature
Closed, ResolvedPublic
Actions

Description

@DAlangi_WMF and @Krinkle wrote on change 949110

Introduced in I0667a026 (in 2019) and used for consistency by default in BagOStuff::set(), even for the 99% of values that don't need segmentation.

The method was removed from use in I830c78a50 due to the overhead of SerializedValueContainer being undesirable, so there is no longer a use case for it. If a value doesn't need segmentation, it shouldn't be wrapped in SerializedValueContainer.

Details

Other Assignee
ArielGlenn
SubjectRepoBranchLines +/-
objectcache: Drop SerializedValueContainer::isUnifiedmediawiki/coremaster+5 -22
objectcache: Deprecate `SerializedValueContainer::isUnified()`mediawiki/coremaster+7 -4
objectcache: Drop `SerializedValueContainer::newUnified()`mediawiki/coremaster+1 -13
objectcache: Hard deprecate SerializedValueContainer::newUnified()mediawiki/coremaster+4 -0
Customize query in gerrit

Event Timeline

Krinkle created this task.Aug 18 2023, 9:29 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 18 2023, 9:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Aug 18 2023, 9:29 PM

Change 949110 had a related patch set uploaded (by Krinkle; author: Derick Alangi):

[mediawiki/core@master] objectcache: Hard deprecate SerializedValueContainer::newUnified()

https://gerrit.wikimedia.org/r/949110

gerritbot added a project: Patch-For-Review.Aug 18 2023, 9:29 PM
Krinkle moved this task from Inbox, needs triage to Blocked/waiting on the MediaWiki-Platform-Team board.Aug 18 2023, 9:29 PM
gerritbot added a comment.Aug 18 2023, 9:44 PM

Change 949110 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Hard deprecate SerializedValueContainer::newUnified()

https://gerrit.wikimedia.org/r/949110

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2023, 10:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 8:02 PM
Krinkle triaged this task as Low priority.Sep 11 2023, 1:24 PM
larissagaulia added a project: MediaWiki-Engineering-Group-onboarding.Oct 4 2023, 12:46 PM
larissagaulia updated Other Assignee, added: ArielGlenn.
larissagaulia subscribed.

@DAlangi_WMF Will add a couple of steps to describe what needs to be done to close this task.

larissagaulia moved this task from Blocked/waiting to Soon on the MediaWiki-Platform-Team board.Oct 9 2023, 1:40 PM
DAlangi_WMF changed the task status from Open to In Progress.Mar 18 2024, 9:46 AM
DAlangi_WMF raised the priority of this task from Low to Medium.
DAlangi_WMF moved this task from Soon to Current Sprint on the MediaWiki-Platform-Team board.
gerritbot added a comment.Mar 18 2024, 9:50 AM

Change 1012348 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] objectcache: Drop `SerializedValueContainer::newUnified()`

https://gerrit.wikimedia.org/r/1012348

gerritbot added a project: Patch-For-Review.Mar 18 2024, 9:50 AM
gerritbot added a comment.Mar 18 2024, 1:46 PM

Change 1012348 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Drop `SerializedValueContainer::newUnified()`

https://gerrit.wikimedia.org/r/1012348

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 18 2024, 2:00 PM
DAlangi_WMF closed this task as Resolved.Mar 18 2024, 2:04 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 18 2024, 2:31 PM
Krinkle added a comment.Mar 18 2024, 8:53 PM

@DAlangi_WMF With the unified container, and the way to create a unified container, gone. Can we remove the isUnified() callers, function, and SCHEMA_UNIFIED constant as well? Those callers should be impossible now.

DAlangi_WMF added a comment.Mar 19 2024, 10:21 AM
In T344521#9639996, @Krinkle wrote:

@DAlangi_WMF With the unified container, and the way to create a unified container, gone. Can we remove the isUnified() callers, function, and SCHEMA_UNIFIED constant as well? Those callers should be impossible now.

Yes we can remove it but since it's a public method, this would need to go through the deprecation process right? I can remove callers, and just hard deprecate this immediately, not sure about complete removal though.

1 usage in MediumSpecificBagOStuff: https://codesearch.wmcloud.org/search/?q=%3A%3AisUnified%5C%28&files=&excludeFiles=&repos=

DAlangi_WMF reopened this task as Open.Mar 19 2024, 10:22 AM
gerritbot added a comment.Mar 19 2024, 10:26 AM

Change 1012619 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] objectcache: Deprecate `SerializedValueContainer::isUnified()`

https://gerrit.wikimedia.org/r/1012619

gerritbot added a project: Patch-For-Review.Mar 19 2024, 10:26 AM
DAlangi_WMF edited projects, added MW-1.43-release; removed MediaWiki-Engineering-Group-onboarding, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Mar 19 2024, 10:49 AM
gerritbot added a comment.Mar 19 2024, 6:18 PM

Change 1012619 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Deprecate `SerializedValueContainer::isUnified()`

https://gerrit.wikimedia.org/r/1012619

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2024, 6:31 PM
DAlangi_WMF moved this task from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.Mar 19 2024, 6:48 PM

This will wait again till 1.43 before we remove the method and close this task.

DAlangi_WMF lowered the priority of this task from Medium to Low.Mar 19 2024, 6:49 PM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.24; 2024-03-26); removed MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 19 2024, 7:00 PM
Reedy moved this task from Blocker to Deprecate or remove on the MW-1.43-release board.Apr 2 2024, 9:26 AM
Krinkle moved this task from Blocked/waiting to Soon on the MediaWiki-Platform-Team board.Mon, Apr 22, 8:01 PM

Moving to "Soon", given that MW 1.43 development has begun.

DAlangi_WMF moved this task from Soon to Current Sprint on the MediaWiki-Platform-Team board.Tue, Apr 23, 10:55 AM
gerritbot added a comment.Tue, Apr 23, 2:49 PM

Change #1023446 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] objectcache: Drop SerializedValueContainer::isUnified

https://gerrit.wikimedia.org/r/1023446

gerritbot added a project: Patch-For-Review.Tue, Apr 23, 2:49 PM
gerritbot added a comment.Wed, Apr 24, 3:55 PM

Change #1023446 merged by jenkins-bot:

[mediawiki/core@master] objectcache: Drop SerializedValueContainer::isUnified

https://gerrit.wikimedia.org/r/1023446

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Wed, Apr 24, 4:00 PM
DAlangi_WMF closed this task as Resolved.Wed, Apr 24, 4:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL