Maniphest T344749

Refactor import-db and update-db into one script
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tchanders
	Aug 22 2023, 5:13 PM

Tags

Referenced Files

None

Subscribers

Description

These two scripts essentially do the same thing, so should be combined. Then bugs like T341660 can be fixed just once.

Details

	Title	Reference	Author	Source Branch	Dest Branch
	Add 'import' mode to the script that outputs the .sql file	repos/mediawiki/services/ipoid!61	tchanders	refactor-import-data	main
	Refactor import-data.js	repos/mediawiki/services/ipoid!59	stran	refactor-import-data	main

Customize query in GitLab

Related Objects
Search...

		Status	Subtype	Assigned	Task
		In Progress		Niharika	T324492 Temporary accounts - MVP
		Open		None	T340895 [Epic] IP Info accommodations for temporary accounts
		Open		STran	T341395 Display Spur data on IPInfo infobox
		Resolved		kostajh	T339284 Deploy ipoid
		Resolved		kostajh	T340984 Fix problems with data import
		Resolved		STran	T344749 Refactor import-db and update-db into one script
		Resolved		STran	T341122 Implement daily data update routine
		Resolved		Tchanders	T344517 Fix statements generated for updated IP data
		Resolved		Tchanders	T344520 Remove temporary files to avoid taking up unnecessary disk space
		Resolved		STran	T344272 Use batching for daily data import
		Resolved		STran	T325630 Implement call to data vendor
		Resolved		Tchanders	T344499 Move behaviors/proxies/tunnels processing into an independent script
		Declined		None	T344939 Log when the lookup fails on attempting to INSERT to actor_data (because the proxy/behaviour doesn't exist)
		Resolved		Tchanders	T344921 Ensure dependent SQL statements are all run in the same batch
		Resolved		Tchanders	T344981 Map tables should not have null for any of their values
		Resolved		STran	T345757 Create orchestration script for daily data update
		Resolved		None	T345761 Turn scripts into modules that export
		Resolved		STran	T345684 Implement batch tracking for imports
		Open	BUG REPORT	Tchanders	T341660 Investigate non-deterministic behaviour of import

Event Timeline

Tchanders created this task.Aug 22 2023, 5:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2023, 5:13 PM

Tchanders mentioned this in T341660: Investigate non-deterministic behaviour of import.Aug 22 2023, 5:13 PM

Tchanders added a parent task: T340984: Fix problems with data import.Aug 23 2023, 1:51 PM

Tchanders added a subtask: T341122: Implement daily data update routine.Aug 23 2023, 1:57 PM

STran claimed this task.Sep 1 2023, 9:37 AM

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 1 2023, 9:59 AM

stran updated https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/59

Refactor import-data.js

tchanders merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/59

Refactor import-data.js

tchanders opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/61

Add 'import' mode to the script that outputs the .sql file

tchanders opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/62

Add 'import' mode to the script that outputs the .sql file

tchanders opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/63

Add 'import' mode to the script that outputs the .sql file

stran merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/61

Add 'import' mode to the script that outputs the .sql file

Tchanders closed this task as Resolved.Sep 11 2023, 6:25 PM

Tchanders moved this task from Backlog to Done on the iPoid-Service board.

STran closed subtask T341122: Implement daily data update routine as Resolved.Dec 12 2023, 8:40 AM