| Esanders | |
| Aug 30 2023, 5:38 PM |
| F37643136: image.png | |
| Aug 30 2023, 5:45 PM |
More or less all the selectors listed here should be removed and replaced with the mw-no-invert classes being added directly:
https://github.com/wikimedia/mediawiki-extensions-DarkMode/blob/4d265fbfb987fb230ab61d736a2217cbcb7dda3a/resources/ext.DarkMode.less#L56-L67
See also T311835
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Jdrewniak | T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations | |||
| Open | Jdrewniak | T341632 [EPIC] Palette customizations and dark mode | |||
| In Progress | Feature | None | T26070 [GOAL] Provide a dark / night mode skin or theme | ||
| Open | None | T345281 Mark non-<img> images with .mw-no-invert |
Change 953703 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/core@master] TitleOptionWidget: Mark thumbnails with mw-no-invert
Another problem with listing out the classes upstream, is downstream changes causing elements to become double inverted, such as is currently happening in the Vector 2022 search component:
If this component were using mw-no-invert, it would be much clearer to developers when double inverting might be happening.
Change 953706 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/RelatedArticles@master] Add mw-no-invert class to thumbnails
Change 953709 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Add mw-no-invert class to thumbnails
Change 953710 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/ContentTranslation@master] Add mw-no-invert class to thumbnails
Change 953709 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Add mw-no-invert class to thumbnails
Change 956844 had a related patch set uploaded (by Esanders; author: Esanders):
[design/codex@main] Add mw-no-invert class to thumbnails
Change 956882 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/MultimediaViewer@master] Add mw-no-invert class to MMV overlay
The use case for .mwe-math-element is slightly different. In that case we have formulae (text) being rendered as an <img>, which gets no-inverted, but as it is actually text we want it invert it.
The hack in place is that we invert the container so that the formula gets triple(!)-inverted.
We should introduce an .mw-invert class that can be used on an <img>, or other elements targeted generically for non-inversion, to force inversion.
Edit: This would also be used by .mw-kartographer-map, where we want to invert map tiles.
Change 956844 merged by jenkins-bot:
[design/codex@main] Add cdx-no-invert class to thumbnails
Change 953710 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Add mw-no-invert class to thumbnails
Note that in https://gerrit.wikimedia.org/r/c/design/codex/+/956844/ it was decided to use an mw-agnostic name cdx-no-invert instead, per discussion there:
Eric Gardner
Is there some other way we could apply this class – say inside the Codex ResourceModule? So far we have tried to keep the Codex code MediaWiki-agnostic as a matter of principle.
I think a wiki-specific module stylesheet for Codex (and/or maybe skin-style overrides) might be a better place for rules like this to live.
Esanders
If the mw naming is a problem, we could use a codex variant e.g. "cdx-no-invert" (or whatever your naming scheme recommends), and then add that selector upstream to the dark mode implementation. Per the task, the dark mode implementation shouldn't be enumerating every selector in every extensions that produces a background image, but have a one selector for MW, one for Codex, one for OOUI, etc. seems reasonable.
Esanders
This would also help standalone Codex provide its own dark mode in the future.
Eric Gardner
I've updated this to be "cdx-no-invert" and I've stashed the name in the constants file along with a note about why this exists.
This will need to be added upstream.
Change 959744 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/Math@master] Add mw-invert class to <img> which generates text
Change 959745 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/Kartographer@master] Add mw-invert to map tiles
Change 959747 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DarkMode@master] Remove downstream selectors for non-inversion
Change 959748 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DarkMode@master] Introduce mw-invert
Change 959744 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Add mw-invert class to <img> which generates text
Change 961452 had a related patch set uploaded (by VolkerE; author: VolkerE):
[mediawiki/core@master] Update Codex from v0.19.0 to v0.20.0
Change 953703 merged by jenkins-bot:
[mediawiki/core@master] TitleOptionWidget: Mark thumbnails with mw-no-invert
Change 963725 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/GrowthExperiments@master] Add mw-no-invert class to thumbnails
Change 956882 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Add mw-no-invert class to MMV overlay
Change 953706 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Add mw-no-invert class to thumbnails
Change 963725 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add mw-no-invert class to thumbnails
Change 959745 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Add mw-invert to map tiles
Change 959747 merged by jenkins-bot:
[mediawiki/extensions/DarkMode@master] Remove downstream selectors for non-inversion
Change 959748 merged by jenkins-bot:
[mediawiki/extensions/DarkMode@master] Introduce mw-invert
Change 1008885 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/Score@master] Add mw-invert class to images
Change 1008889 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/wikihiero@master] Add mw-invert to images