Page MenuHomePhabricator

Add support for read new for pagelinks
Closed, ResolvedPublic

Description

Using LinksMigration and LinkTargetStore services. Several extensions also need to be updated.

Progress:

Event Timeline

Ladsgroup triaged this task as Medium priority.Sep 15 2023, 5:45 PM
Ladsgroup moved this task from Triage to In progress on the DBA board.

Change 957968 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SpecialWhatLinksHere: Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/957968

Change 957968 merged by jenkins-bot:

[mediawiki/core@master] SpecialWhatLinksHere: Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/957968

Change 958956 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] specials: Add support for pagelinks read new in SpecialMostLinked

https://gerrit.wikimedia.org/r/958956

Change 958958 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] cache: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/958958

Change 958956 merged by jenkins-bot:

[mediawiki/core@master] specials: Add support for pagelinks read new in SpecialMostLinked

https://gerrit.wikimedia.org/r/958956

Change 958958 merged by jenkins-bot:

[mediawiki/core@master] cache: Add support for pagelinks read new in BacklinkCache

https://gerrit.wikimedia.org/r/958958

Change 964554 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SpecialExport: Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/964554

From what I'm seeing, in core we only need to adapt:

  • MergeHistory
  • Title:: getBrokenLinksFrom (maybe we can just drop it)
  • SpecialLonelyPages
  • SpecialWantedPages

Change 964554 merged by jenkins-bot:

[mediawiki/core@master] SpecialExport: Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/964554

Change 964980 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SpecialWantedPages: Support READ_NEW for pagelinks

https://gerrit.wikimedia.org/r/964980

Change 964980 merged by jenkins-bot:

[mediawiki/core@master] SpecialWantedPages: Support READ_NEW for pagelinks

https://gerrit.wikimedia.org/r/964980

Change 965149 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] dumpLinks: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/965149

Change 965149 merged by jenkins-bot:

[mediawiki/core@master] dumpLinks: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/965149

Change 966641 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] MergeHistory: Support for pagelinks migration

https://gerrit.wikimedia.org/r/966641

Change 966641 merged by jenkins-bot:

[mediawiki/core@master] MergeHistory: Support for pagelinks migration

https://gerrit.wikimedia.org/r/966641

Change 966614 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@REL1_41] MergeHistory: Support for pagelinks migration

https://gerrit.wikimedia.org/r/966614

Change 966614 merged by jenkins-bot:

[mediawiki/core@REL1_41] MergeHistory: Support for pagelinks migration

https://gerrit.wikimedia.org/r/966614

Change 970344 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] Drop Title::getBrokenLinksFrom()

https://gerrit.wikimedia.org/r/970344

Change 970344 merged by jenkins-bot:

[mediawiki/core@master] Deprecate Title::getBrokenLinksFrom()

https://gerrit.wikimedia.org/r/970344

Change 970817 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/ProofreadPage@master] Add support for pagelinks migration read new

https://gerrit.wikimedia.org/r/970817

Change 970822 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/PageImages@master] Add support for read new of pagelinks migration

https://gerrit.wikimedia.org/r/970822

Likely rMW25f71099a999: Deprecate Title::getBrokenLinksFrom() is causing this:

[2023-11-02T11:09:22.792476+00:00] error.ERROR: [29414d557537ead0e2335aa4] /wiki/Special:BrokenRedirects   PHP Notice: Undefined variable: toObj {"exception":"[object] (ErrorException(code: 0): PHP Notice: Undefined variable: toObj at /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specials/SpecialBrokenRedirects.php:137)
[stacktrace]
#0 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specials/SpecialBrokenRedirects.php(137): MWExceptionHandler::handleError()
#1 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specialpage/QueryPage.php(890): MediaWiki\\Specials\\SpecialBrokenRedirects->formatResult()
#2 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specialpage/QueryPage.php(856): MediaWiki\\SpecialPage\\QueryPage->outputResults()
#3 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specials/SpecialBrokenRedirects.php(193): MediaWiki\\SpecialPage\\QueryPage->execute()
#4 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specialpage/SpecialPage.php(727): MediaWiki\\Specials\\SpecialBrokenRedirects->execute()
#5 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/specialpage/SpecialPageFactory.php(1623): MediaWiki\\SpecialPage\\SpecialPage->run()
#6 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/MediaWiki.php(357): MediaWiki\\SpecialPage\\SpecialPageFactory->executePath()
#7 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/MediaWiki.php(960): MediaWiki->performRequest()
#8 /srv/mediawiki/tags/2023-11-01_14:56:06/includes/MediaWiki.php(613): MediaWiki->main()
#9 /srv/mediawiki/tags/2023-11-01_14:56:06/index.php(50): MediaWiki->run()
#10 /srv/mediawiki/tags/2023-11-01_14:56:06/index.php(46): wfIndexMain()
#11 {main}
","exception_url":"/wiki/Special:BrokenRedirects","reqId":"29414d557537ead0e2335aa4","caught_by":"mwe_handler"} []

Change 971132 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SpecialBrokenRedirects: Make sure $toObj is always set

https://gerrit.wikimedia.org/r/971132

Change 971132 merged by jenkins-bot:

[mediawiki/core@master] SpecialBrokenRedirects: Make sure $toObj is always set

https://gerrit.wikimedia.org/r/971132

Change 971219 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/PageTriage@master] Migrate to SQB for ArticleCompile

https://gerrit.wikimedia.org/r/971219

Change 970817 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Add support for pagelinks migration read new

https://gerrit.wikimedia.org/r/970817

Change 970822 merged by jenkins-bot:

[mediawiki/extensions/PageImages@master] Add support for read new of pagelinks migration

https://gerrit.wikimedia.org/r/970822

Change 971219 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Migrate to SQB for ArticleCompile

https://gerrit.wikimedia.org/r/971219

Change 972482 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/FlaggedRevs@master] Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/972482

Change 972482 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/972482

Change 973238 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/PageTriage@master] ArticleCompileLinkCount: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/973238

Change 973241 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Disambiguator@master] Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/973241

Change 973244 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] SpecialLonelyPages: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/973244

Change 973244 merged by jenkins-bot:

[mediawiki/core@master] SpecialLonelyPages: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/973244

Change 973241 merged by jenkins-bot:

[mediawiki/extensions/Disambiguator@master] Add support for read new of pagelinks

https://gerrit.wikimedia.org/r/973241

Change 973238 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] ArticleCompileLinkCount: Add support for pagelinks read new

https://gerrit.wikimedia.org/r/973238

Ladsgroup updated the task description. (Show Details)
Ladsgroup moved this task from In progress to Done on the DBA board.