Page MenuHomePhabricator
Create Task
Maniphest T347961

Geo Analytics: Remove indentation from response (minify response)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Epic: T288305: AQS 2.0: Geo Analytics Service

Description

All 2.0 services responded with an indented response body but traffic team warned us about that because responses were bigger than before (66% bigger in some cases). That's why we decided to remove indentation from responses for all services. Because some of them were already deployed, this work is still pending for geo-analytics

Acceptance Criteria

  • Indentation has been removed for any response (including healthz endpoint)

Required

  • Run unit and integration tests after removing indentation

Details

SubjectRepoBranchLines +/-
Geo Analytics: Remove indentation from response (minify response)generated-data-platform/aqs/geo-analyticsmain+3 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sfaci created this task.Oct 3 2023, 10:25 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2023, 10:25 AM
Sfaci moved this task from Incoming to Sprint 02 on the Data Products board.Oct 3 2023, 1:44 PM
Sfaci edited projects, added Data Products (Sprint 02); removed Data Products.
Sfaci triaged this task as Medium priority.Oct 3 2023, 2:05 PM
Sfaci added a subscriber: SGupta-WMF.Oct 6 2023, 6:00 AM
Sfaci added a parent task: T288305: AQS 2.0: Geo Analytics Service.Oct 6 2023, 6:21 AM
Sfaci mentioned this in T348565: Estimate Sprint 02 tasks - Santi.Oct 11 2023, 12:59 PM
WDoranWMF set the point value for this task to 1.Oct 17 2023, 11:09 AM
WDoranWMF moved this task from Sprint Backlog to Teleport to Sprint 03 on the Data Products (Sprint 02) board.Oct 24 2023, 12:56 PM
WDoranWMF edited projects, added Data Products (Data Products (Sprint 03)); removed Data Products (Sprint 02).
WDoranWMF moved this task from Sprint Backlog to Wormhole to Sprint 04 on the Data Products (Data Products (Sprint 03)) board.Nov 16 2023, 1:37 PM
WDoranWMF edited projects, added Data Products (Data Products Sprint 04); removed Data Products (Data Products (Sprint 03)).
gerritbot added a comment.Nov 22 2023, 12:20 PM

Change 976693 had a related patch set uploaded (by Jennifer Ebe; author: Jennifer Ebe):

[generated-data-platform/aqs/geo-analytics@main] Geo Analytics: Remove indentation from response (minify response)

https://gerrit.wikimedia.org/r/976693

gerritbot added a project: Patch-For-Review.Nov 22 2023, 12:20 PM
JEbe-WMF claimed this task.Nov 22 2023, 12:23 PM
JEbe-WMF moved this task from Sprint Backlog to Code Review / Tech Input on the Data Products (Data Products Sprint 04) board.Nov 22 2023, 1:13 PM
WDoranWMF reassigned this task from JEbe-WMF to SGupta-WMF.Nov 23 2023, 1:11 PM
WDoranWMF added a subscriber: JEbe-WMF.
gerritbot added a comment.Nov 27 2023, 9:44 AM

Change 976693 merged by Sg912:

[generated-data-platform/aqs/geo-analytics@main] Geo Analytics: Remove indentation from response (minify response)

https://gerrit.wikimedia.org/r/976693

SGupta-WMF reassigned this task from SGupta-WMF to EChukwukere-WMF.Nov 27 2023, 9:45 AM
SGupta-WMF moved this task from Code Review / Tech Input to Testing on the Data Products (Data Products Sprint 04) board.
Maintenance_bot removed a project: Patch-For-Review.Nov 27 2023, 10:10 AM
EChukwukere-WMF added a comment.Dec 5 2023, 4:37 AM

Test status: QA PASS

After pulling the lastest changes and running locally for device analytics, tests run as expected on the assignef port 8090

import requests


base_url = "http://localhost:8090/metrics/unique-devices/en.wikipedia/all-sites/daily/20180101/20180105"

header = {"accept": "application/json",
          "user-agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/104.0.0.0 Safari/537.36"}

response = requests.get(base_url, headers=header)


print(f"The response status code is: {response.status_code}")
print(response.json())

Screenshot 2023-12-04 at 10.36.39 PM.png (939×1 px, 198 KB)

EChukwukere-WMF moved this task from Testing to Done on the Data Products (Data Products Sprint 04) board.Dec 5 2023, 4:38 AM
Sfaci moved this task from Incoming to DONE on the AQS2.0 board.Jan 15 2024, 1:12 PM
WDoranWMF closed this task as Resolved.Jan 24 2024, 4:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL