⚓ T348072 [Sub Task] Add more text style formatting functions to NativeEditor toolbar

Status	Assigned	Task
Open	None	T344258 [Main Epic] 2023-2024 Enhancements to Editing on the iOS app
Open	None	T344282 [Sub Epic] Make the iOS editor native
Resolved	JTannerWMF	T347928 [Task] Add formatting options to NativeEditor tool bar
Resolved	JTannerWMF	T348072 [Sub Task] Add more text style formatting functions to NativeEditor toolbar

Seddon created this task.Oct 3 2023, 9:45 PM

Seddon updated the task description. (Show Details)

Seddon renamed this task from Add more text style formatting functions to Add more text style formatting functions to NativeEditor toolbar.Oct 3 2023, 9:47 PM

Seddon updated the task description. (Show Details)

Seddon mentioned this in T347928: [Task] Add formatting options to NativeEditor tool bar.

Seddon renamed this task from Add more text style formatting functions to NativeEditor toolbar to [Sub Task] Add more text style formatting functions to NativeEditor toolbar.Oct 4 2023, 12:52 AM

Seddon updated the task description. (Show Details)Oct 4 2023, 1:47 AM

Seddon updated the task description. (Show Details)Oct 4 2023, 1:53 AM

Seddon updated the task description. (Show Details)Oct 4 2023, 1:57 AM

Seddon moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.Oct 13 2023, 12:15 PM

Seddon triaged this task as Low priority.Oct 13 2023, 2:12 PM

Tsevener claimed this task.Dec 14 2023, 7:00 PM

Tsevener added a project: iOS Release FY2023-24 (Archive).

Tsevener moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.

References PR: https://github.com/wikimedia/wikipedia-ios/pull/4705

Strikethrough PR: https://github.com/wikimedia/wikipedia-ios/pull/4706

Tsevener updated the task description. (Show Details)Dec 15 2023, 9:16 PM

@Mazevedo Can you create PRs for underline (), subscript (), and superscript () support? I have already created a strikethrough PR that you can reference - you'll need to make new Objective-C formatter classes and button action extensions for each of these 3 types, but the logic for these will be very similar to what you see in that PR (I only expect the regex and the toggle starting/ending formatting strings to need changing). You'll also need to make the other PR changes that you see in the mediator and view controller for these new types.

The color of the tags should be the same green as the strikethrough (<s></s>) tags in that PR. The text within can remain the standard base formatting (i.e. black text for .light theme). You might be able to avoid some minor duplicate work if you first merge the strikethrough PR before creating your new branches off of main.

Note there's some trickiness in exposing your new Objective-C formatting classes to the rest of the project. The readme should help you here.

Thanks!

Tsevener reassigned this task from Tsevener to Mazevedo.Dec 15 2023, 9:47 PM

Tsevener moved this task from Doing to Ready for Development on the iOS Release FY2023-24 (Archive) board.

Tsevener subscribed.

Mazevedo moved this task from Ready for Development to Doing on the iOS Release FY2023-24 (Archive) board.Dec 21 2023, 1:05 PM

Underline, subscript and superscript https://github.com/wikimedia/wikipedia-ios/pull/4709

Tsevener updated the task description. (Show Details)Jan 8 2024, 3:09 PM

Tsevener removed Mazevedo as the assignee of this task.Jan 17 2024, 5:11 PM

Tsevener moved this task from Doing to Ready for Development on the iOS Release FY2023-24 (Archive) board.

Tsevener claimed this task.Jan 19 2024, 9:35 PM

Tsevener raised the priority of this task from Low to Medium.