Wrong font size in OOUI dropdowns in Vector
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Oct 10 2023, 7:09 PM

Description

OOUI dropdowns in Vector (both modern and legacy) use different font size than the forms themselves. This is a regression in MW 1.41.0-wmf.30.

Steps to reproduce:

Visit Special:WhatLinksHere (or any other special page with a dropdown menu)
Click the dropdown handle

Vector 2022:

Incorrect (1.41.0-wmf.30)	Correct (1.41.0-wmf.29)
https://www.mediawiki.org/wiki/Special:WhatLinksHere?useskin=vector-2022	https://en.wikipedia.org/wiki/Special:WhatLinksHere?useskin=vector-2022

Vector legacy:

Incorrect (1.41.0-wmf.30)	Correct (1.41.0-wmf.29)
https://www.mediawiki.org/wiki/Special:WhatLinksHere?useskin=vector	https://en.wikipedia.org/wiki/Special:WhatLinksHere?useskin=vector

Other skins are not affected, for example Timeless:

Correct (1.41.0-wmf.30)	Correct (1.41.0-wmf.29)
https://www.mediawiki.org/wiki/Special:WhatLinksHere?useskin=timeless	https://en.wikipedia.org/wiki/Special:WhatLinksHere?useskin=timeless

QA Results - Prod

AC	Status	Details
1	✅	T348572#9251916

Details

Subject	Repo	Branch	Lines +/-
Move @font-size-base into mediawiki.skin.variables.less	mediawiki/skins/Vector	wmf/1.41.0-wmf.30	+5 -3
Move @font-size-base into mediawiki.skin.variables.less	mediawiki/skins/Vector	master	+5 -3
Move font-size declaration into skin variables	mediawiki/skins/Vector	master	+1 -2

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	hashar	T347081 1.41.0-wmf.30 deployment blockers
		Resolved		Edtadros	T348572 Wrong font size in OOUI dropdowns in Vector

Event Timeline

matmarex created this task.Oct 10 2023, 7:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2023, 7:09 PM

matmarex triaged this task as Unbreak Now! priority.Oct 10 2023, 7:09 PM

matmarex added a parent task: T347081: 1.41.0-wmf.30 deployment blockers.

Probably more fallout from T345766. See T348530

Change 964972 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964972

gerritbot added a project: Patch-For-Review.Oct 10 2023, 8:00 PM

Change 964976 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Move font-size declaration into skin variables

https://gerrit.wikimedia.org/r/964976

Change 964977 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Simplify teleport styles

https://gerrit.wikimedia.org/r/964977

T345766 is somewhat related, but it's also related to work on standardizing a teleport target: T347199 and simplifying our font size stack.

On long term we should do this to simplify this further: https://gerrit.wikimedia.org/r/964977

(FWIW this looks like an improvement to me but I understand it's unintended!)

Change 964976 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Move font-size declaration into skin variables

Reason:

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/964972

https://gerrit.wikimedia.org/r/964976

Jdlrobson added a project: Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1).Oct 10 2023, 8:18 PM

Jdlrobson moved this task from Incoming to Needs More Work on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 8:23 PM

Change 964601 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.30] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964601

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1) board.Oct 10 2023, 9:38 PM

Change 964972 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964972

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.1; 2023-10-17).Oct 10 2023, 10:00 PM

I verified in Pixel there are no UI regressions with this change but it does need to be backported.
https://pixel.wmcloud.org/reports/desktop/index.html

Change 964601 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.30] Move @font-size-base into mediawiki.skin.variables.less

https://gerrit.wikimedia.org/r/964601

Mentioned in SAL (#wikimedia-operations) [2023-10-11T08:00:02Z] <hashar@deploy2002> Synchronized php-1.41.0-wmf.30/skins/Vector: Backports for Vector styling issues T348572 T348530 (duration: 06m 16s)

Stashbot mentioned this in T348530: Less_Exception_Compiler: variable @min-width-desktop-wide is undefined in file /srv/mediawiki/php-1.41.0-wmf.30/skins/Vector/skinStyles/ext.echo.styles.alert.less in ext.echo.styles.alert.less on line 22, column 2320.Oct 11 2023, 8:00 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 11 2023, 8:00 AM

I have deployed the backport, the font size looks fine now on mediawiki.org (thanks for the test links and screenshots!)

@matmarex I forgot to thank you this morning for the very nice bug report. I have used the URLs to verify the deployment and the screenshots provided a very nice explanation of the defect I had to verify. Kudos!

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Steps to reproduce:

Visit Special:WhatLinksHere (or any other special page with a dropdown menu)
Click the dropdown handle

✅ AC1: The font in the drop down should be the same size as the other fonts sizes on the forms.
@Jdlrobson, these were not validated in beta, please take a look at them. I did also verify that in timeless the font is the same as other font sizes.

Vector 2022:

https://www.mediawiki.org/wiki/Special:WhatLinksHere?useskin=vector-2022