Change 966867 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/deployment-charts@master] [WIP] ipoid: Set PROXY_HOST and PROXY_PORT

https://gerrit.wikimedia.org/r/966867

Change 966867 abandoned by Kosta Harlan:

[operations/deployment-charts@master] [WIP] ipoid: Set PROXY_HOST and PROXY_PORT

Reason:

https://gerrit.wikimedia.org/r/966867

tchanders merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/144

get-feed: Support using a proxy with axios

@Tchanders please use the environmental variable HTTPS_PROXY (vs HTTP_PROXY), as is the convention we use in the repo, along with https_proxy, when applications need to reach a url via https. Additionally, no ENV variable is needed for the proxy's port, as this is included in the URI we provide to the ENV.

This is a bit on me, I wanted to comment on the related patch, but failed to, I am terribly sorry

Thanks @jijiki .

I've put up a patch renaming HTTP_PROXY to HTTPS_PROXY throughout the repo.

Re: the port, do you mean that the port is included in the HTTPS_PROXY variable, or that it's in a separate variable? If the first, then we don't need to update anything. If the second, then I think we need to know the name of that variable so we can update get-feed to use it:

const proxyUrl = new URL( process.env.HTTPS_PROXY );
axiosParams.proxy = {
	host: proxyUrl.hostname,
	port: proxyUrl.port // <---- needs to reference the variable containing the port, if it's a separate variable
};

tchanders opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/152

Rename HTTP_PROXY to HTTPS_PROXY

kharlan merged https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/152

Rename HTTP_PROXY to HTTPS_PROXY

I think we will QA this by testing it in production, so skipping the QA column and moving to Done. (cc @dom_walden)

In T349171#9287152, @Tchanders wrote:

Thanks @jijiki .

I've put up a patch renaming HTTP_PROXY to HTTPS_PROXY throughout the repo.

Re: the port, do you mean that the port is included in the HTTPS_PROXY variable, or that it's in a separate variable? If the first, then we don't need to update anything. If the second, then I think we need to know the name of that variable so we can update get-feed to use it:

const proxyUrl = new URL( process.env.HTTPS_PROXY );
axiosParams.proxy = {
	host: proxyUrl.hostname,
	port: proxyUrl.port // <---- needs to reference the variable containing the port, if it's a separate variable
};

@Tchanders looking in operations/deployment-charts repo, the HTTPS_PROXY variable will be http://url-downloader.eqiad.wikimedia.org:8080, so, as you say, we shouldn't need to do anything else here.