Vector 2022: Big font in OOUI windows and popups
Closed, DuplicatePublicBUG REPORT
Actions

Assigned To

Authored By

	Msz2001
	Nov 3 2023, 11:04 AM

Description

Steps to replicate the issue (include links if applicable):

Navigate to RecentChanges on eg. enwiki ( https://en.wikipedia.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&urlversion=2&uselang=en )
Open filters field
Look at the font in the filter options

Another example:

Navigate to https://pl.wikipedia.org/wiki/Wikipedia
Open "Narzędzia" page tools menu
Click on "Zgłoś błąd"
Compare the dialog font and the page font size

What happens?:
The font is significantly bigger than the font of the page content (on RecentChanges checkbox labels are 18px vs 14px content). In the OOUI window of the gadget the font size is 16px whereas it used to be 14px, just like the page content.

What should have happened instead?:
The font should match the document font or at least should not be overwhelming.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
The issue seems to be similar to one about font size in edit/preview mode that was reported (and fixed) few months ago: T321728

(RecentChanges on enwiki)

(Report error dialog on plwiki)

QA Results - Prod

AC	Status	Details
1	✅	T350467#9342931

Details

	Subject	Repo	Branch	Lines +/-
	Attach OOUI content to teleport target instead of <body>	mediawiki/core	master	+6 -7

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Duplicate	BUG REPORT	matmarex	T350467 Vector 2022: Big font in OOUI windows and popups
Resolved		matmarex	T348287 Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target
Resolved		Jdlrobson	T348289 Migrate Vector skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target
Resolved		matmarex	T348286 Move the default OOUI overlay and window manager inside the MediaWiki teleport target

Event Timeline

Msz2001 created this task.Nov 3 2023, 11:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2023, 11:04 AM

Jdlrobson added a project: Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3).Nov 3 2023, 2:14 PM

Jdlrobson moved this task from Incoming to typography/darkmode on the Desktop Improvements (Vector 2022) board.Nov 3 2023, 7:08 PM

@matmarex I am not too familiar with this code but think this is because it's not using #mw-teleport-target ?
https://gerrit.wikimedia.org/g/mediawiki/core/+/fc416810884157087c7d6946961df94b8cb41e94/resources/src/mediawiki.rcfilters/ui/MainWrapperWidget.js#76

Restricted Application added a project: Growth-Team. · View Herald TranscriptNov 3 2023, 7:19 PM

Change 971519 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Attach OOUI content to teleport target instead of <body>

https://gerrit.wikimedia.org/r/971519

gerritbot added a project: Patch-For-Review.Nov 3 2023, 9:32 PM

matmarex claimed this task.Nov 3 2023, 9:32 PM

matmarex added a subtask: T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.

Change 971519 merged by jenkins-bot:

[mediawiki/core@master] Attach OOUI content to teleport target instead of <body>

https://gerrit.wikimedia.org/r/971519

Maintenance_bot removed a project: Patch-For-Review.Nov 4 2023, 12:10 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.4; 2023-11-07).Nov 4 2023, 1:00 AM

Izno mentioned this in T332120: Replace deprecated WikimediaUI Base aliases with current Codex design tokens.Nov 4 2023, 5:08 AM

Nardog removed a subtask: T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.Nov 4 2023, 10:05 AM

Nardog added a parent task: T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.

Nardog subscribed.

matmarex removed a parent task: T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.Nov 6 2023, 12:17 AM

matmarex added a subtask: T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.

matmarex closed this task as a duplicate of T350544: OOUI widgets now have huge fonts and misaligned buttons in some places.Nov 6 2023, 12:22 AM

Nardog mentioned this in T348286: Move the default OOUI overlay and window manager inside the MediaWiki teleport target.Nov 9 2023, 8:07 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki, plwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Navigate to RecentChanges on eg. enwiki ( https://en.wikipedia.org/wiki/Special:RecentChanges?hidebots=1&hidecategorization=1&hideWikibase=1&limit=50&days=7&urlversion=2&uselang=en )
Open filters field
Look at the font in the filter options
Another example:

Navigate to https://pl.wikipedia.org/wiki/Wikipedia
Open "Narzędzia" page tools menu
Click on "Zgłoś błąd"
Compare the dialog font and the page font size

✅ AC1: The font should match the document font or at least should not be overwhelming.

Edtadros updated the task description. (Show Details)Nov 19 2023, 1:42 AM

Edtadros mentioned this in T350414: Verify 1.42.0-wmf.4 deployment.Nov 19 2023, 2:45 AM

	F41519134: screenshot 242.png
	Nov 19 2023, 1:40 AM

	F41519133: screenshot 241.png
	Nov 19 2023, 1:40 AM

	F41519132: screenshot 239.png
	Nov 19 2023, 1:40 AM

	F41519131: screenshot 240.png
	Nov 19 2023, 1:40 AM

Vector 2022: Big font in OOUI windows and popupsClosed, DuplicatePublicBUG REPORTActions