Page MenuHomePhabricator

DiscussionTools: Expand section arrow is misplaced on mobile
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Msz2001
Nov 12 2023, 8:19 PM
Referenced Files
F41508678: image.png
Nov 15 2023, 7:57 PM
F41508652: IMG_8812.jpg
Nov 15 2023, 7:46 PM
F41508370: OOUI - MediaWiki 2.jpeg
Nov 15 2023, 7:25 PM
F41508367: OOUI - MediaWiki.jpeg
Nov 15 2023, 7:25 PM
F41508356: IMG_8589.jpg
Nov 15 2023, 7:25 PM
F41508355: IMG_8590.PNG
Nov 15 2023, 7:25 PM
F41498307: image.png
Nov 12 2023, 8:20 PM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The down arrow is not placed vertically in the middle of the heading. Instead, it's moved to the top.

What should have happened instead?:
The arrow should be centered vertically.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

image.png (337×490 px, 23 KB)

The following rule seems to override the default centered placement:

.mw-mf .ext-discussiontools-init-section {
    display: flex;
    align-items: flex-start !important; /* This one overrides .client-js .section-heading { align-items: center; } */
}

Event Timeline

Side-effect of the change for T344629, I guess.

Change 973445 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Only change mobile indicator alignment when enhancements are enabled

https://gerrit.wikimedia.org/r/973445

Change 973445 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Only change mobile indicator alignment when enhancements are enabled

https://gerrit.wikimedia.org/r/973445

EAkinloose subscribed.

✅ Expand section Arrow is properly aligned

Tested on mediawiki and enbeta. Both mobile and desktop just in case

Before fix:

IMG_8590.PNG (2×1 px, 449 KB)

IMG_8589.jpg (2×1 px, 1 MB)

After fix:

OOUI - MediaWiki.jpeg (2×1 px, 905 KB)

OOUI - MediaWiki 2.jpeg (2×1 px, 1008 KB)

Side-effect of the change for T344629, I guess.

I could be wrong but this seems similar to https://phabricator.wikimedia.org/T344548.

Looking at the alignment of the ellipsis in T344629 after fix, it might be a good idea to align the Edit icon as well.

Is it intentional to align to align the items center or are we sticking to leaving it as top aligned as is in T444629.

IMG_8812.jpg (2×1 px, 1022 KB)

It's intentional for them to center-aligned on pages without visual enhancements, but they should still be top-aligned on pages with them.

e.g.

image.png (1×826 px, 105 KB)