Page MenuHomePhabricator

[CLIENT] Use expression builder instead of raw SQL in Wikibase
Open, Needs TriagePublic

Description

See parent tasks for more context.

In Wikibase client, there are a number of places which build raw SQL expressions rather than use the expression builder. Searching for the terms detailed in the parent task provides the code points seen in the codesearch results. In order top better facilitate separation of concerns in our code, these should be updated to utilize the mediawiki expression builder.

See grandparent task for examples of adoption.

Acceptance Criteria

  • No code points in WikibaseClient build raw SQL expressions.

Event Timeline

Prio Notes:

Impact AreaAffected
production / end usersno
monitoringno
development effortsyes
onboarding effortsmaybe
additional stakeholdersyes
ItamarWMDE renamed this task from [CLIENT] Use expression builder instead of raw SQL in Wikibase to [CLIENT] [SW] Use expression builder instead of raw SQL in Wikibase.Jan 16 2024, 4:54 PM
ItamarWMDE moved this task from [DOT] By Project to [DOT] Prioritized on the wmde-wikidata-tech board.
ArthurTaylor renamed this task from [CLIENT] [SW] Use expression builder instead of raw SQL in Wikibase to [CLIENT] Use expression builder instead of raw SQL in Wikibase.Feb 28 2024, 10:15 AM
ArthurTaylor updated the task description. (Show Details)

Change #1019776 had a related patch set uploaded (by Atieno; author: Atieno):

[mediawiki/extensions/Wikibase@master] Migrate buildLike, addQuotes, makeList to expression builder

https://gerrit.wikimedia.org/r/1019776