Page MenuHomePhabricator

Update the list of ReferenceTooltips and NavigationPopups gadgets
Closed, ResolvedPublic

Description

The ReferenceTooltips and NavigationPopups gadgets add a similar behavior to wikis like Page-Previews and Reference Previews do. That's why the code detects if on of these is enabled by the user and the disable the according feature in the extension. To do that the extension needs to know the local name of the gadget. This list is maintained in the production settings files in wgPopupsConflictingRefTooltipsGadgetName and wgPopupsConflictingNavPopupsGadgetName

We also would like to know which projects have the ReferenceTooltips gadget enabled by default to eventually reach out when the Reference Previews feature is deployed.

Acceptance criteria:

  • Check the current list of local gadget names configured and update it for new/missing names [1] [2] [3]
  • Leave out wikis that don't have the Page-Previews extension enabled
  • Check projects for both gadgets and where they are enabled as a default

[1] https://global-search.toolforge.org/?q=rt-tooltipContent&regex=1&ignorecase=1&namespaces=8&title=Gadget-.*%5C.js *
[2] https://global-search.toolforge.org/?q=newNavpopup&regex=1&ignorecase=1&namespaces=8&title=Gadget-.*%5C.js *
*) This search does not include results where the gadget scripts include the code from a different source.
[3] https://gitlab.com/wmde/technical-wishes/gadget-checker

Code to review:

Results

  • The NavigationPopups gadget is not a default anywhere.
  • The list of wikis that have ReferenceTooltips as a default can be found in our gitlab repo default_conflicts.csv

Event Timeline

Change 974984 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[operations/mediawiki-config@master] Update the list of ReferenceTooltip gadget names

https://gerrit.wikimedia.org/r/974984

Change 975021 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[operations/mediawiki-config@master] Update the list of NavigationPopups gadget names

https://gerrit.wikimedia.org/r/975021

Change 974984 merged by jenkins-bot:

[operations/mediawiki-config@master] Update the list of ReferenceTooltip gadget names

https://gerrit.wikimedia.org/r/974984

Change 975021 merged by jenkins-bot:

[operations/mediawiki-config@master] Update the list of NavigationPopups gadget names

https://gerrit.wikimedia.org/r/975021

Mentioned in SAL (#wikimedia-operations) [2023-11-20T14:16:37Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:974984|Update the list of ReferenceTooltip gadget names (T351314)]], [[gerrit:975021|Update the list of NavigationPopups gadget names (T351314)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-20T14:17:54Z] <urbanecm@deploy2002> urbanecm and wmde-fisch: Backport for [[gerrit:974984|Update the list of ReferenceTooltip gadget names (T351314)]], [[gerrit:975021|Update the list of NavigationPopups gadget names (T351314)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-20T14:26:26Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:974984|Update the list of ReferenceTooltip gadget names (T351314)]], [[gerrit:975021|Update the list of NavigationPopups gadget names (T351314)]] (duration: 09m 48s)

awight updated the task description. (Show Details)
awight moved this task from Doing to Review on the WMDE-TechWish-Maintenance-2023 board.

Check projects for both gadgets and where they are enabled as a default

Sorry I just updated the requirement after a quick chat to PM. We want to have a list for each Gadget. The proposed patch only adds one for ReferenceToolips like originally written in the ticket.