When checking for the civi table wmf_external_contact_identifiers, found 53 rows that needs to move to fundraiseup_id;
MariaDB [civicrm]> select * from wmf_external_contact_identifiers where venmo_user_name <> '' and venmo_user_name not like '@%' and LENGTH(venmo_user_name) = 8;
Could this change be the cause? https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/968790
It seems right, but those ternary conditions can be tricky. Maybe let's rewrite that to span a few more lines?
Oh we have venmo under fundraiseup, that's the issue, we need to add additional check if the gateway is fundraise up then ignore the check for venmo_user_name https://civicrm.wikimedia.org/civicrm/contact/view?reset=1&cid=48637637&selectedChild=contribute
@AnnWF can we check the other way? So only if the gateway is Braintree and the method is venmo we use venmo_user_name, otherwise <gateway>_id
Change 974724 had a related patch set uploaded (by Wfan; author: Wfan):
[wikimedia/fundraising/crm@master] For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name
Change 974936 had a related patch set uploaded (by Wfan; author: Wfan):
[wikimedia/fundraising/crm@master] Move current fundraiseup venmo user name back to fundraiseup_id
Change 974724 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] For fundraiseup venmo, save fundraiseup_id instead of venmo_user_name
Change 974936 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Move current fundraiseup venmo user name back to fundraiseup_id