@MSuijkerbuijk_WMF and @AKanji-WMF : sorry, this might not actually need a change!

Some questions to clarify the desired functionality:

In T358878#9596774, @AnnWF wrote:

From slack, we need to make unsubscribe success message is not confusing for this 90 days snooze donor: sorry to see you go, you're unsubscribed OR thanks for updating your preferences, you will not receive emails to this address for 90 days.

Hah, now it's got country but I'm seeing a missing payments_final_status

In T362087#9740701, @MSuijkerbuijk_WMF wrote:

@Ejegg Thanks for explaining. Just a follow up questions:

• Is the 'Recurring Upgrade Declined' a criteria in Acoustic? I don't remember if we added it already.

• Does it have an expiration period? I'm asking because we need to leave a window with the Declined on, but then after (for example) +12 months, reintroduce them. Is this how this criteria works?

Thanks

In T362087#9707794, @krobinson wrote:

@Ejegg this is great!

Can I confirm a couple of things:

• Can we use that for other donors with other CIDs, so that if a donor just emails us saying never monthly etc, we can mark their record? Or is it only for those who have received the email and thus already have their record marked in some way?

@krobinson You can add the 'Recurring Upgrade Declined' activity to any contact and it will act as an opt-out to future recurring upgrade emails - it's not dependent on having already gotten one.

In T362087#9711941, @MSuijkerbuijk_WMF wrote:

Thanks @Ejegg -- what do you mean with exclude all donors when they have 'Update recurring contribution'? Do you mean all those who receive the email?
We do not want to do that. Many donors did not open, but that doesn't mean we don't want to reach them again with an upgrade ask and be successful.

@MSuijkerbuijk_WMF when Donor Relations manually edits a recurring contribution, e.g. for a donor that emailed them instead of clicking a link in the email, the donor's record gets an activity of type 'Update recurring contribution'. The vast majority of the people who got the email will NOT get an activity of this type.

The associated patch is merged. Is there more to review?

I've just deployed a change to make it possible to manually record a 'Recurring Upgrade Decline' activity against a contact record, for donors who receive the email asking them to upgrade their recurring, but who reach out to DR instead of clicking the 'no' button. Adding this activity will exclude them from future mailings.

I think it should accept them ever since this commit: https://phabricator.wikimedia.org/rWFSP3dee4c1549a8c4e6cfc760cb7a3f63d4ef1dad1a

Thanks @Pcoombe . Creating a custom skin sounds fun, and the faster load times might give a nice boost for donations!

• How is the checksum column populated for contacts? Could something have gone wrong there?

@Pcoombe brought up in a meeting that we need to update the parameters we pass through to the Thank You pages. To avoid really long URLs, he suggests we do a hard cutover in the payments-wiki code. This means he will need to update the TY page javascript to accept both prefixes for a while.

Hi @AMJohnson I can't seem to sign in to Zendesk either via Okta or with my old password, and the reset password link doesn't send me anything. Are you able to reactivate agent accounts?

Thanks @AMJohnson, that is good information.

Thanks for checking @ppenloglou! So I wonder how that full real URL gets translated to the long gibberish links.email.wikimedia.org URL that we see in the screenshot, and how the long URL gets translated back to the one with the full params. If it's something dynamic I guess it's possible that Acoustic could break a link after send. Could it have to do with the fact that their email address isn't in Acoustic?

For donor 397205, it does look like a bad link. That screencap seems to be the text-only version of the email. Has that been QA'ed? Can we check that the checksum token is there in the text-only version?

Oops, we added this to the IPN listener but now the Civi queue consumer doesn't know what to do with it: https://civicrm.wikimedia.org/civicrm/damaged/edit?id=619453

@AKanji-WMF it would be nice, but maybe next sprint. The checksums shouldn't expire for 30 days, so this feature can wait a little bit

Oho, our RecurUpgradeMessage is not the culprit here.

Just to follow up, we were able to change the viewport in the rendered HTML, and that change went out today.

No issues, this looks fine

OK, I have deployed the fixes to track the parameters when they decline and to pass the parameters along to the TY pages.

Nice @SHust, glad to hear you were able to fix i!

Still trying to replicate this on dev - I created two recurring donations with the older one a braintree one, then upgraded the second. The email correctly referred to the upgrade amount of the second donation, not the first.

It'll probably be an improvement for the EmailPreferences page too! I'll see what the best way to change that in the rendered HTML is so we don't get a restyling flash when the JS runs.

@ehughes thanks for the new CSS! I've just deployed it along with the uploaded image.

This is deployed to track the wmf_ parameters when they accept the upgrade, but doesn't yet work to track the parameters when they decline the upgrade. I'll try to get that done tomorrow. Also still in the works: passing the parameters along to the TY page.

In Tech Talk we just decided it's OK to add these as activity custom fields.

OK @ehughes , that change is live on the recurring upgraded form. It should only pass through the YYYY-MM-DD now.

Hi @ehughes, I've got a patch in review to strip the time off and just send those first ten chars: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DonationInterface/+/1010700

@MSuijkerbuijk_WMF we don't have any company cards to test with, so when we QA things the testers just make a small donation (which Donor Relations can later refund), then use their own Civi record.

You can get links from a donor's CiviCRM contact summary page (I'm not pasting mine publicly as it'll let anyone reading this change my donation amount) on the right column in the 'Donor Prefs Links' section. The format will be:

https://donorpreferences.wikimedia.org/index.php?title=Special:RecurUpgrade/recurUpgrade&variant=v01&contact_id=CIDTOKENGOESHERE&checksum=CHECKSUMTOKENGOESHERE

OK, the redirect part of this is done - either outcome on the form (upgrade or cancel) now redirects to ThankYou wiki with the params we discussed

Related: T263282: Handled delete deleted contacts when they have contributions - eg. cid 30379649 and T205941: Investigate/ repair deleted contacts with contributions