Maniphest T359694

More amount validation for recurring upgrade
Closed, ResolvedPublic
Actions

Description

Server-side validation to make sure it's not negative
Maximum amount calculated with currency code

Details

	Subject	Repo	Branch	Lines +/-
	Better amount validation for RecurUpgrade	mediawiki/extensions/DonationInterface	master	+44 -16

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		AKanji-WMF	T325317 How can we enable upgrading of existing recurring donation amount?
		Resolved		Ejegg	T359694 More amount validation for recurring upgrade

Event Timeline

Ejegg created this task.Mar 9 2024, 1:41 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2024, 1:41 AM

Ejegg added a parent task: T325317: How can we enable upgrading of existing recurring donation amount?.Mar 9 2024, 1:41 AM

XenoRyet added a project: Fundraising Sprint: didAnyoneTryThis().Mar 11 2024, 8:08 PM

XenoRyet moved this task from Triage to Current Sprint on the Fundraising-Backlog board.

Ejegg claimed this task.Mar 11 2024, 9:13 PM

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: didAnyoneTryThis() board.

Change 1010560 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] Better amount validation for RecurUpgrade

https://gerrit.wikimedia.org/r/1010560

gerritbot added a project: Patch-For-Review.Mar 12 2024, 4:37 PM

XenoRyet added a project: Fundraising Sprint: explain($LikeImFive).Mar 12 2024, 7:25 PM

Ejegg moved this task from Doing to Ready for Review on the Fundraising Sprint: didAnyoneTryThis() board.Mar 13 2024, 2:53 AM

Change 1010560 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Better amount validation for RecurUpgrade

https://gerrit.wikimedia.org/r/1010560

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 5:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 13 2024, 7:01 PM

Ejegg moved this task from Backlog to Done on the Fundraising Sprint: explain($LikeImFive) board.Mar 18 2024, 7:37 PM

XenoRyet closed this task as Resolved.Mar 25 2024, 7:16 PM

XenoRyet set Final Story Points to 2.