Maniphest T351672

Don't failmail when CiviMail records can't be written/updated
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Ejegg
	Nov 20 2023, 7:23 PM

Tags

Referenced Files

None

Subscribers

Description

We got a failmail today triggered by a failure in the last step of a monthly convert recurring donation import, when we had already recorded the donation and send an extra thank you mail, but were just marking the civiMail record as delivered.

We should treat CiviMail records as 'nice to have' and not dump the message on the damaged pile if the only thing that goes wrong when processing it is with the CiviMail record.

Details

	Subject	Repo	Branch	Lines +/-
	Treat CiviMail records as best-effort	wikimedia/fundraising/crm	master	+16 -8

Customize query in gerrit

Event Timeline

Ejegg created this task.Nov 20 2023, 7:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2023, 7:23 PM

Ejegg added a project: Fundraising Tech - Chaos Crew.Nov 20 2023, 7:24 PM

Ejegg moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.

Change 975884 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Treat CiviMail records as best-effort

https://gerrit.wikimedia.org/r/975884

gerritbot added a project: Patch-For-Review.Nov 20 2023, 7:24 PM

Ejegg moved this task from Backlog to Ready for Review on the Fundraising Tech - Chaos Crew board.Nov 20 2023, 7:24 PM

AnnWF moved this task from Ready for Review to Being Reviewed on the Fundraising Tech - Chaos Crew board.Nov 20 2023, 7:38 PM

AnnWF moved this task from Being Reviewed to Pending Deployment on the Fundraising Tech - Chaos Crew board.

Change 975884 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Treat CiviMail records as best-effort

https://gerrit.wikimedia.org/r/975884

Maintenance_bot removed a project: Patch-For-Review.Nov 20 2023, 8:10 PM

Ejegg moved this task from Pending Deployment to Done on the Fundraising Tech - Chaos Crew board.Nov 21 2023, 2:45 AM

greg triaged this task as Medium priority.Nov 21 2023, 11:31 PM

XenoRyet closed this task as Resolved.Dec 4 2023, 8:29 PM

XenoRyet set Final Story Points to 1.

Dwisehaupt moved this task from Done to Completed 20231121 - 20231205 on the Fundraising Tech - Chaos Crew board.Dec 5 2023, 8:21 PM