Page MenuHomePhabricator

New upstream release for Pygments (2.17.2)
Closed, ResolvedPublicFeature

Description

A new upstream version of Pygments is now available: 2.17.2.

Wikimedia production wikis are currently using 2.16.1 via shellbox. The beta cluster is using 2.16.0 via the bundled version of Pygments in the extension. Upstream's change log for 2.16.1-2.17.2 includes updates for the wikitext lexer from @Diskdance:

Previously: T335460: New upstream release for Pygments (2.16.1)
Next: T364249: New upstream release for Pygments (2.18.0)

Event Timeline

bd808 triaged this task as Medium priority.Nov 21 2023, 4:37 PM
bd808 changed the subtype of this task from "Task" to "Feature Request".
bd808 updated the task description. (Show Details)
bd808 renamed this task from New upstream release for Pygments (2.17.1) to New upstream release for Pygments (2.17.2).Dec 1 2023, 10:03 PM
bd808 changed the task status from Open to In Progress.Dec 1 2023, 10:34 PM
bd808 claimed this task.

I have been preparing the PHP version bump patches using the wiki deployed as https://mwdemo.toolforge.org/. This has worked well for me and deserves a bit of documentation here in case I forget what I have been doing before the next iteration.

$ ssh dev.toolforge.org
$ become mwdemo
$ cd ~/public_html/w/extensions/SyntaxHighlight_GeSHi/pygments/
$ ./create_pygmentize_bundle
$ webservice shell
$ cd ~/public_html/w
$ php ./extensions/SyntaxHighlight_GeSHi/maintenance/updateCSS.php
$ php ./extensions/SyntaxHighlight_GeSHi/maintenance/updateLexerList.php
$ exit
$ git status
$ git diff
$ git commit --all
$ git format-patch HEAD^..HEAD

Then I pull the patch back to my laptop using scp, apply it to a local checkout of extensions/SyntaxHighlight_GeSHi, and submit the changeset to gerrit for review. There isn't anything special about doing the prep work on Toolforge; it's just a convenient and functional MediaWiki environment for me to use.

Change 979422 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update Pygments to 2.17.2

https://gerrit.wikimedia.org/r/979422

Change 979423 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[mediawiki/libs/Shellbox@master] syntaxhighlight: Update Pygments to 2.17.2

https://gerrit.wikimedia.org/r/979423

Change 979422 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Update Pygments to 2.17.2

https://gerrit.wikimedia.org/r/979422

Change 979423 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] syntaxhighlight: Update Pygments to 2.17.2

https://gerrit.wikimedia.org/r/979423

Change 983222 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] shellbox: Bump to 2023-12-14-055615

https://gerrit.wikimedia.org/r/983222

Change 983222 merged by jenkins-bot:

[operations/deployment-charts@master] shellbox: Bump to 2023-12-14-055615

https://gerrit.wikimedia.org/r/983222

Wikimedia production deployment of the shellbox containers followed the process from https://wikitech.wikimedia.org/wiki/Shellbox#Deploying_a_new_version

cd /srv/deployment-charts/helmfile.d/services
DC=staging
for deployment in shellbox*; do
  echo "#### Doing $deployment in $DC"
  sleep 5
  pushd $deployment; helmfile -e $DC -i apply --context 5; popd
  kube_env $deployment $DC
  curl https://staging.svc.eqiad.wmnet:$(kubectl get service shellbox-main-tls-service -o jsonpath='{.spec.ports[0].nodePort}')
done

Repeated with DC=eqiad and DC=codfw.

I think I remember from past deploys of this stuff that it will take the wikis about an hour for caches to expire such that Special:Version shows the new Pygments version.