There should also be unit testing. And by that we mean something under tests/phpunit/integration/includes/Rest/ Either a new test file for the new RootSpecHandler, or additional tests added for any of the changed classes.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Add phpunit test for RootSpecHandler | mediawiki/core | master | +139 -18 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Stalled | None | T324931 Clean up open RESTBase related tickets | |||
| In Progress | None | T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset | |||
| Open | None | T353157 Port CampaignEvents REST API documentation to swagger | |||
| In Progress | daniel | T362006 Provide a Swagger-UI for exploring the core REST API | |||
| Resolved | BPirkle | T323786 REST framework: Add support for outputting an OpenAPI (swagger) spec | |||
| Open | None | T350161 Cleanup: REST framework: Add support for outputting an OpenAPI (swagger) spec | |||
| Resolved | Atieno | T352664 Add unit testing for RootSpecHandler |
Event Timeline
Comment Actions
Hi @Atieno, can you please associate one or more active project tags with this task (via the Add Action... → Change Project Tags dropdown)? That will allow to see a task when looking at project workboards or searching for tasks in certain projects, and get notified about a task when watching a related project tag. Thanks!
Comment Actions
Change 980051 had a related patch set uploaded (by Atieno; author: Daniel Kinzler):
[mediawiki/core@master] Add phpunit test for RootSpecHandler
Comment Actions
Jenkins failure is because the change that added the RootSpecHandler was reverted from master. Once that is brought back in will revoke this again and get it nerge-able
Comment Actions
Change 980051 merged by jenkins-bot:
[mediawiki/core@master] Add phpunit test for RootSpecHandler