Page MenuHomePhabricator

Remove custom error printing code from MWException, fall back to default MWExceptionRenderer
Closed, ResolvedPublic

Description

I've been reading this code while working on T313841 (trying to remove the uses of $wgCommandLineMode) and I noticed that MWException::report() and MWExceptionRenderer::output() do mostly the same things. It seems that MWExceptionRenderer is able to handle any exception type, so surely it should handle MWException too. (But note that there are interesting subclasses like ErrorPageError which probably still need something special.)

I looked at some commits that introduced this code, and making changes like this has already been suggested in code review of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/463308 in 2018.

Event Timeline

Change 983218 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] [WIP] Deprecate error printing in MWException

https://gerrit.wikimedia.org/r/983218

Change 983219 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] [WIP] Remove error printing in MWException

https://gerrit.wikimedia.org/r/983219

Change 983218 merged by jenkins-bot:

[mediawiki/core@master] Deprecate error printing in MWException

https://gerrit.wikimedia.org/r/983218

matmarex added a project: MW-1.43-release.

(Deprecated in MW 1.42, removal planned for MW 1.43)

Change #983219 merged by jenkins-bot:

[mediawiki/core@master] Remove error printing in MWException

https://gerrit.wikimedia.org/r/983219