Page MenuHomePhabricator
Create Task
Maniphest T354505

Disabling two-factor authentication is broken
Closed, ResolvedPublicBUG REPORT
Actions

Description

nahidunlimited@mwmaint2002:~$ mwscript extensions/OATHAuth/maintenance/disableOATHAuthForUser.php --wiki=metawiki <x>

Instead of disabling the 2FA of the user, running the above script gives me the following error,

Wikimedia\Services\NoSuchServiceException from line 431 of /srv/mediawiki/php-1.42.0-wmf.12/vendor/wikimedia/services/src/ServiceContainer.php: No such service: OATHAuthUserRepository
#0 /srv/mediawiki/php-1.42.0-wmf.12/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService('OATHAuthUserRep...')
#1 /srv/mediawiki/php-1.42.0-wmf.12/includes/MediaWikiServices.php(351): Wikimedia\Services\ServiceContainer->getService('OATHAuthUserRep...')
#2 /srv/mediawiki/php-1.42.0-wmf.12/extensions/OATHAuth/src/OATHAuthServices.php(62): MediaWiki\MediaWikiServices->getService('OATHAuthUserRep...')
#3 /srv/mediawiki/php-1.42.0-wmf.12/extensions/OATHAuth/maintenance/disableOATHAuthForUser.php(31): MediaWiki\Extension\OATHAuth\OATHAuthServices->getUserRepository()
#4 /srv/mediawiki/php-1.42.0-wmf.12/maintenance/includes/MaintenanceRunner.php(703): DisableOATHAuthForUser->execute()
#5 /srv/mediawiki/php-1.42.0-wmf.12/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run()
#6 /srv/mediawiki/multiversion/MWScript.php(158): require_once('/srv/mediawiki/...')
#7 {main}

Then I tried using the special page on Meta, https://meta.wikimedia.org/wiki/Special:DisableOATHForUser. This too was showing the following error,

[03952002-1314-4556-8007-af0799a881ae] 2024-01-08 06:11:14: Fatal exception of type "Error"

Looks like a similar error also occurred on this user's end: T354492

Details

SubjectRepoBranchLines +/-
OATHAuthServices: Fix service namemediawiki/extensions/OATHAuthmaster+1 -1
Fix disabling two-factor authenticationmediawiki/extensions/OATHAuthmaster+6 -1
Fix disabling two-factor authenticationmediawiki/extensions/OATHAuthwmf/1.42.0-wmf.12+6 -1
OATHAuthServices: Fix service namemediawiki/extensions/OATHAuthwmf/1.42.0-wmf.12+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Nahid created this task.Jan 8 2024, 6:32 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2024, 6:32 AM
gerritbot added a comment.Jan 8 2024, 9:41 AM

Change 988213 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] Fix disabling two-factor authentication

https://gerrit.wikimedia.org/r/988213

gerritbot added a project: Patch-For-Review.Jan 8 2024, 9:41 AM
taavi claimed this task.Jan 8 2024, 9:41 AM
taavi triaged this task as High priority.
taavi added a project: Regression.
gerritbot added a comment.Jan 8 2024, 9:54 AM

Change 988413 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] OATHAuthServices: Fix service name

https://gerrit.wikimedia.org/r/988413

taavi merged a task: T354518: "DisableOATHForUser: Error: Call to a member function getName() on null" trying to disable TOTP in user preferences.Jan 8 2024, 10:20 AM
gerritbot added a comment.Jan 8 2024, 11:14 AM

Change 988413 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHAuthServices: Fix service name

https://gerrit.wikimedia.org/r/988413

gerritbot added a comment.Jan 8 2024, 11:14 AM

Change 988213 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Fix disabling two-factor authentication

https://gerrit.wikimedia.org/r/988213

gerritbot added a comment.Jan 8 2024, 11:22 AM

Change 988252 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@wmf/1.42.0-wmf.12] OATHAuthServices: Fix service name

https://gerrit.wikimedia.org/r/988252

gerritbot added a comment.Jan 8 2024, 11:23 AM

Change 988253 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@wmf/1.42.0-wmf.12] Fix disabling two-factor authentication

https://gerrit.wikimedia.org/r/988253

taavi renamed this task from OATHAuth's disableOATHAuthForUser.php script issue to Disabling two-factor authentication is broken.Jan 8 2024, 11:26 AM
gerritbot added a comment.Jan 8 2024, 11:36 AM

Change 988252 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@wmf/1.42.0-wmf.12] OATHAuthServices: Fix service name

https://gerrit.wikimedia.org/r/988252

gerritbot added a comment.Jan 8 2024, 11:36 AM

Change 988253 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@wmf/1.42.0-wmf.12] Fix disabling two-factor authentication

https://gerrit.wikimedia.org/r/988253

Stashbot added a comment.Jan 8 2024, 11:36 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T11:36:31Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:988252|OATHAuthServices: Fix service name (T354505)]], [[gerrit:988253|Fix disabling two-factor authentication (T354505)]]

Stashbot added a comment.Jan 8 2024, 11:38 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T11:38:02Z] <taavi@deploy2002> taavi: Backport for [[gerrit:988252|OATHAuthServices: Fix service name (T354505)]], [[gerrit:988253|Fix disabling two-factor authentication (T354505)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 8 2024, 11:45 AM

Mentioned in SAL (#wikimedia-operations) [2024-01-08T11:45:52Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:988252|OATHAuthServices: Fix service name (T354505)]], [[gerrit:988253|Fix disabling two-factor authentication (T354505)]] (duration: 09m 21s)

taavi closed this task as Resolved.Jan 8 2024, 11:46 AM
Nahid added a comment.Jan 8 2024, 11:57 AM

Thank you, kindly.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Jan 8 2024, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 8 2024, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL