Page MenuHomePhabricator
Create Task
Maniphest T354907

(mw.track) migrate MediaWiki.RevisionSlider.timing.init to statslib
Closed, DuplicatePublic
Actions

Description

Follow the migration process as outlined below.

  • Secure/Conduct a code review.
  • Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
  • Verify that the changes have been successfully implemented.
  • Update the dashboard by replacing the old Graphite metric with the new Prometheus metric.

Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

Related Objects
Search...

Event Timeline

lmata created this task.Jan 11 2024, 9:37 PM
lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Jan 11 2024, 9:44 PM
lmata edited projects, added SRE Observability (FY2023/2024-Q3); removed SRE Observability (FY2023/2024-Q2).Jan 12 2024, 5:36 PM
DAlangi_WMF added a comment.Jan 23 2024, 12:54 PM

@colewhite, this metric is tracked in JS land using the mw.track() method (doc) in ResourceLoader. I'm not sure we have an equivalent for statsLib yet.

We may need to incorporate statsLib support in ResourceLoader so code in JS space can send stats. I'll Cc @Krinkle for some inputs or coordinate async.

colewhite added a comment.Jan 24 2024, 12:27 AM
In T354907#9480808, @DAlangi_WMF wrote:

We may need to incorporate statsLib support in ResourceLoader so code in JS space can send stats.

You're right, this is beyond the reach of StatsLib right now. On first glance, it also appears to suffer from the same unstructured interface that prevented an easy migration away from StatsD in the first place. :(

I'm not sure there's much we can do about this one until we identify a path forward. It needs some research.

colewhite mentioned this in T355837: Add Prometheus support to statsd.js via mw.track().Jan 25 2024, 12:31 AM
colewhite removed a project: SRE Observability (FY2023/2024-Q3).Apr 3 2024, 11:06 PM
colewhite renamed this task from migrate MediaWiki.RevisionSlider.timing.init to statslib to (mw.track) migrate MediaWiki.RevisionSlider.timing.init to statslib.Apr 4 2024, 2:48 PM
colewhite closed this task as a duplicate of T359277: (mw.track) Migrate MediaWiki.RevisionSlider to statslib.Apr 26 2024, 4:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL