| DLynch | |
| Jan 24 2024, 5:02 PM |
| F41714272: image.png | |
| Jan 24 2024, 5:02 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
Highlight cursor / selections appear massively offset from the underlying text.
What should have happened instead?:
Cursor / highlight should match the position of the underlying text.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Release | hashar | T354433 1.42.0-wmf.15 deployment blockers | ||
| Resolved | BUG REPORT | Jdforrester-WMF | T355805 Syntax highlighting in 2017 wikitext editor has extreme vertical cursor displacement |
Git bisect indicates that this is caused by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/989911 in Vector (T352875).
Change 992760 had a related patch set uploaded (by DLynch; author: DLynch):
[VisualEditor/VisualEditor@master] Zero out padding in source mode paragraphs as well
Change 992774 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):
[mediawiki/skins/Vector@master] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"
Change 992774 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"
Change 992775 had a related patch set uploaded (by Jforrester; author: Jdrewniak):
[mediawiki/skins/Vector@wmf/1.42.0-wmf.15] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"
Change 992775 merged by jenkins-bot:
[mediawiki/skins/Vector@wmf/1.42.0-wmf.15] Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more"
Mentioned in SAL (#wikimedia-operations) [2024-01-24T23:19:29Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:992775|Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more" (T355805 T354433)]]
Mentioned in SAL (#wikimedia-operations) [2024-01-24T23:21:01Z] <jforrester@deploy2002> jforrester: Backport for [[gerrit:992775|Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more" (T355805 T354433)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-01-24T23:32:59Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:992775|Revert "Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more" (T355805 T354433)]] (duration: 13m 29s)
Change 993505 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Update <p> spacing to improve consistency of ul/ol spacing, also update heading spacing to be more consistent, relying on mw defaults more (attempt 2)
Change 992760 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Zero out padding in source mode paragraphs as well
Change 997584 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4ec4a75e4)
Change 997584 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4ec4a75e4)