We would like to remove the themeStyles feature from CodexModule, but VueTest still uses it to load the demos. We'll have to find some sort of way to load the right file without using themeStyles, perhaps using a custom package file contents callback.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove Codex demos from VueTest | mediawiki/extensions/VueTest | master | +5 -76 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | CCiufo-WMF | T335317 [EPIC] Determine how to support code-splitting when using Codex inside MediaWiki | |||
| Resolved | BUG REPORT | ovasileva | T350069 message boxes visually change when full Codex styles module is loaded | ||
| Invalid | Feature | None | T338911 Optimize codex-search-styles | ||
| In Progress | Catrope | T349423 [EPIC] Implement Codex code splitting in ResourceLoader\CodexModule | |||
| Resolved | Catrope | T355842 Remove themeStyles support from CodexModule | |||
| Declined | None | T355841 Remove use of themeStyles in VueTest |
Event Timeline
Comment Actions
Per yesterday's discussion, I think the best solution is to simply archive/decommission the Vuetest extension all together. Everything that we created this extension to do has been surpassed (or will be surpassed) by something else:
- For example Vue and Codex code that other developers can study, use CodexExample
- For visual regression testing, running Pixel against the Codex sandbox page is a better approach – there is too much noise with the Pixel tests when they run inside MW, due to other changes in skins/extensions/core.
What would "killing Vuetest" entail?
- Mark the Gerrit repo as archived/read-only, or even just delete it all together. Not sure what we generally do here or who has the necessary privileges.
- Update the MW Page for this extension to indicate that it is no longer active (should probably point folks to CodexExample instead)
- Remove all documentation references to VueTest and update the links to point to CodexExample; this search is a good place to start
- Remove VueTest from any WMF-wide Pixel configuration that is currently deployed (again, not clear who has the authority to do this).
Comment Actions
Change 1003117 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):
[mediawiki/extensions/VueTest@master] Remove Codex demos from VueTest
Comment Actions
Reopening so that we can consider doing this as a faster way to unblock T355842 (rather than blocking that task on the full decommissioning of VueTest).
Comment Actions
Change 1003117 merged by jenkins-bot:
[mediawiki/extensions/VueTest@master] Remove Codex demos from VueTest