Homepage new Impact module: SyntaxError: Unexpected token
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

Logstash link

message

"message": "SyntaxError: Unexpected token '<', \"<!doctype \"... is not valid JSON"

trace

"level": "ERROR",
   "url": "https://en.wikipedia.org/wiki/Special:Homepage?title=Special:Homepage&source=specialconfirmemail&namespace=-1",
  
"stack_trace": "at GrowthTasksApi.handleError  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.DataStore&skin=vector-2022&version=1e1z8:25:852\nat mightThrow  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.NewImpact%2CSuggestedEdits&skin=vector-2022&version=1p84k:163:648\nat process  https://en.wikipedia.org/w/load.php?lang=en&modules=%40wikimedia%2Fcodex%2Cjquery%2Coojs-ui-core%2Cvue%7Cext.growthExperiments.Homepage.NewImpact%2CSuggestedEdits&skin=vector-2022&version=1p84k:164:309",

Impact

2 errors in 24 hours
I was not able to trigger the error in the Console

Details

	Subject	Repo	Branch	Lines +/-
	Handle invalid JSON response and log errors	mediawiki/extensions/GrowthExperiments	master	+2 -0

Customize query in gerrit

Event Timeline

Etonkovidova created this task.Jan 26 2024, 12:05 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2024, 12:05 AM

Etonkovidova updated the task description. (Show Details)Jan 26 2024, 12:05 AM

Etonkovidova renamed this task from SyntaxError: Unexpected token - Homepage new Impact module to Homepage new Impact module: SyntaxError: Unexpected token .Jan 26 2024, 1:02 AM

I think this happened because the API was not working properly for a short while, and someone used Special:Homepage over that period of time. I can't find in the logs which API endpoint exactly triggered this though. If it doesn't keep reoccuring, I think it's a nice-to-fix error scenario. CC @Sgs in case I'm missing something.

Yes it would be nice to handle this error, maybe from composables/useMWRestApi.js since it's coming from NewImpact.

thcipriani moved this task from Untriaged to Jan 2024 on the Wikimedia-production-error board.Feb 17 2024, 12:14 AM

Cyndymediawiksim claimed this task.Feb 20 2024, 10:31 AM

Sgs moved this task from Triaged to Up Next on the Growth-Team board.Feb 20 2024, 11:47 AM

KStoller-WMF set the point value for this task to 2.Feb 20 2024, 4:07 PM

KStoller-WMF triaged this task as Low priority.Feb 20 2024, 5:45 PM

KStoller-WMF raised the priority of this task from Low to Medium.

KStoller-WMF moved this task from Up Next to Sprint 8 (Growth Team) on the Growth-Team board.

KStoller-WMF edited projects, added Growth-Team (Sprint 8 (Growth Team)); removed Growth-Team.

Cyndymediawiksim moved this task from Incoming to Doing on the Growth-Team (Sprint 8 (Growth Team)) board.Feb 25 2024, 8:02 PM

Change 1006174 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Handle invalid JSON response and log errors

https://gerrit.wikimedia.org/r/1006174

gerritbot added a project: Patch-For-Review.Feb 25 2024, 8:52 PM

Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Sprint 8 (Growth Team)) board.Feb 25 2024, 8:54 PM

In T355913#9495249, @Sgs wrote:

Yes it would be nice to handle this error, maybe from composables/useMWRestApi.js since it's coming from NewImpact.

I missed the obvious at GrowthTasksApi.handleError which is the error handler for GrowthTasksApi requests, only used in GrowthTasksApi.fetchTasks. It seems unrelated to NewImpact, the module is pulled in since it's a homepage request. cc @Cyndymediawiksim

Sgs moved this task from Code Review to Doing on the Growth-Team (Sprint 8 (Growth Team)) board.Feb 27 2024, 1:43 PM

Cyndymediawiksim moved this task from Doing to Code Review on the Growth-Team (Sprint 8 (Growth Team)) board.Mar 1 2024, 2:39 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 9 (Growth Team)); removed Growth-Team (Sprint 8 (Growth Team)).Mar 5 2024, 4:20 PM

Sgs moved this task from Incoming to Code Review on the Growth-Team (Sprint 9 (Growth Team)) board.Mar 5 2024, 4:28 PM

In T355913#9490547, @Urbanecm_WMF wrote:

I think this happened because the API was not working properly for a short while, and someone used Special:Homepage over that period of time. I can't find in the logs which API endpoint exactly triggered this though. If it doesn't keep reoccuring, I think it's a nice-to-fix error scenario. CC @Sgs in case I'm missing something.

Just to be clear, we would want to still log the error but have a more meaningful message that we can easily discard while doing team chores. Or on the opposite, are you suggesting that we just catch the error and not produce any logs?

In T355913#9623320, @Sgs wrote:

In T355913#9490547, @Urbanecm_WMF wrote:

I think this happened because the API was not working properly for a short while, and someone used Special:Homepage over that period of time. I can't find in the logs which API endpoint exactly triggered this though. If it doesn't keep reoccuring, I think it's a nice-to-fix error scenario. CC @Sgs in case I'm missing something.

Just to be clear, we would want to still log the error but have a more meaningful message that we can easily discard while doing team chores. Or on the opposite, are you suggesting that we just catch the error and not produce any logs?

The 5xx error message should be logged either way, so it is technically redundant. If we log this explicitly, it might be easier to catch if it is happening too frequently for just our API (if it is happening for all APIs, it'll be noticed by SRE-managed alarms). TLDR: No strong opinion either way, both would be reasonable IMO.

Sgs moved this task from Code Review to QA on the Growth-Team (Sprint 9 (Growth Team)) board.Mar 12 2024, 5:30 PM

Change 1006174 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Handle invalid JSON response and log errors

https://gerrit.wikimedia.org/r/1006174

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2024, 2:31 PM

eunnpixie subscribed.Mar 14 2024, 2:31 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 14 2024, 5:00 PM

Etonkovidova moved this task from QA to Test in Production on the Growth-Team (Sprint 9 (Growth Team)) board.Mar 15 2024, 10:08 PM

Urbanecm_WMF edited projects, added Growth-Team (Sprint 10 (Growth Team)); removed Growth-Team (Sprint 9 (Growth Team)).Mar 19 2024, 2:40 PM

Urbanecm_WMF moved this task from Incoming to Test in Production on the Growth-Team (Sprint 10 (Growth Team)) board.