By following a link from notification alert a "Comment-not-found" error message is shown.
Link provided by notification alert: https://it.wikipedia.org/wiki/Discussioni_utente:Melos?markasread=46597628&markasreadwiki=itwiki#c-Melos-20240130010900-Questo_messaggio!
Link provided by timestamp: https://it.wikipedia.org/wiki/Discussioni_utente:Melos#c-9Aaron3-20240130010900-Questo_messaggio!
Yeah, that seems to be generating the wrong ID for the message. It has the correct section name and timestamp, but the wrong username for some reason.
I can't reproduce this locally -- can you think of any other details about how the comment was left / the notification itself?
You got a new talk message! https://it.wikipedia.org/wiki/Discussioni_utente:DLynch_(WMF)#Test
@Melos -- thanks for leaving a comment on my page on itwiki. I see the issue in the notification I was sent. So now I just need to work out what's different between itwiki and my local dev environment...
Change 994147 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] CommentParser: Ignore generated timestamp links
Is this also the cause for which my manual signature was ignored? (I added the signature manually to avoid the space between the dash and the user name.)
Change 994147 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] CommentParser: Ignore generated timestamp links
Change 994139 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):
[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.15] CommentParser: Ignore generated timestamp links
Change 994140 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):
[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.16] CommentParser: Ignore generated timestamp links
Change 994139 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.15] CommentParser: Ignore generated timestamp links
Change 994140 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@wmf/1.42.0-wmf.16] CommentParser: Ignore generated timestamp links
Mentioned in SAL (#wikimedia-operations) [2024-01-30T14:30:54Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Started scap: Backport for [[gerrit:994139|CommentParser: Ignore generated timestamp links (T356142)]], [[gerrit:994140|CommentParser: Ignore generated timestamp links (T356142)]], [[gerrit:994141|Add maintenance script to list users with invalid signatures (T356168)]]
Mentioned in SAL (#wikimedia-operations) [2024-01-30T14:32:26Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 matmarex and lucaswerkmeister-wmde: Backport for [[gerrit:994139|CommentParser: Ignore generated timestamp links (T356142)]], [[gerrit:994140|CommentParser: Ignore generated timestamp links (T356142)]], [[gerrit:994141|Add maintenance script to list users with invalid signatures (T356168)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)
Mentioned in SAL (#wikimedia-operations) [2024-01-30T14:41:55Z] <logmsgbot> lucaswerkmeister-wmde@deploy2002 Finished scap: Backport for [[gerrit:994139|CommentParser: Ignore generated timestamp links (T356142)]], [[gerrit:994140|CommentParser: Ignore generated timestamp links (T356142)]], [[gerrit:994141|Add maintenance script to list users with invalid signatures (T356168)]] (duration: 11m 01s)
To explain: the signature detection specifically on user talk pages was having some issues, as during the reparse where we checked for new comments the self-link in the timestamp had already been added and was being picked up as a user page link (thus why we were assigning the wrong username to them). We've fixed it so that timestamp links will be ignored now.
The links that were sent out in notifications etc during this period will remain broken because the bad data is attached to them, but we shouldn't be generating any new broken ones now.
Change 994152 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] CommentParser: Add test case for already-linked timestamp
Change 994152 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] CommentParser: Add test case for already-linked timestamp