Page MenuHomePhabricator
Create Task
Maniphest T356322

InvalidArgumentException: Unrecognized 'targets' parameter
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: Unrecognized 'targets' parameter
exception.trace
from /srv/mediawiki/php-1.42.0-wmf.16/extensions/Gadgets/includes/Gadget.php(107)
#0 /srv/mediawiki/php-1.42.0-wmf.16/extensions/Gadgets/includes/MediaWikiGadgetsDefinitionRepo.php(66): MediaWiki\Extension\Gadgets\Gadget->__construct(array)
#1 /srv/mediawiki/php-1.42.0-wmf.16/extensions/Wikisource/includes/HookHandler/SidebarBeforeOutputHandler.php(48): MediaWiki\Extension\Gadgets\MediaWikiGadgetsDefinitionRepo->getGadget(string)
#2 /srv/mediawiki/php-1.42.0-wmf.16/includes/HookContainer/HookContainer.php(159): MediaWiki\Extension\Wikisource\HookHandler\SidebarBeforeOutputHandler->onSidebarBeforeOutput(MediaWiki\Skins\Vector\SkinVectorLegacy, array)
#3 /srv/mediawiki/php-1.42.0-wmf.16/includes/HookContainer/HookRunner.php(3475): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#4 /srv/mediawiki/php-1.42.0-wmf.16/includes/skins/Skin.php(1576): MediaWiki\HookContainer\HookRunner->onSidebarBeforeOutput(MediaWiki\Skins\Vector\SkinVectorLegacy, array)
#5 /srv/mediawiki/php-1.42.0-wmf.16/includes/skins/SkinTemplate.php(604): Skin->buildSidebar()
#6 /srv/mediawiki/php-1.42.0-wmf.16/includes/skins/SkinTemplate.php(181): SkinTemplate->getPortletsTemplateData()
#7 /srv/mediawiki/php-1.42.0-wmf.16/includes/skins/SkinMustache.php(139): SkinTemplate->getTemplateData()
#8 /srv/mediawiki/php-1.42.0-wmf.16/skins/Vector/includes/SkinVectorLegacy.php(161): SkinMustache->getTemplateData()
#9 /srv/mediawiki/php-1.42.0-wmf.16/includes/skins/SkinMustache.php(92): MediaWiki\Skins\Vector\SkinVectorLegacy->getTemplateData()
#10 /srv/mediawiki/php-1.42.0-wmf.16/includes/skins/SkinTemplate.php(174): SkinMustache->generateHTML()
#11 /srv/mediawiki/php-1.42.0-wmf.16/includes/Output/OutputPage.php(3017): SkinTemplate->outputPage()
#12 /srv/mediawiki/php-1.42.0-wmf.16/includes/actions/ActionEntryPoint.php(170): MediaWiki\Output\OutputPage->output(boolean)
#13 /srv/mediawiki/php-1.42.0-wmf.16/includes/MediaWikiEntryPoint.php(185): MediaWiki\Actions\ActionEntryPoint->execute()
#14 /srv/mediawiki/php-1.42.0-wmf.16/index.php(55): MediaWiki\MediaWikiEntryPoint->run()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Notes

These errors started accumulating when I rolled the 1.42.0-wmf.16 train (T354434) to group1, so I rolled the train back.

Details

MediaWiki Version
1.42.0-wmf.16
Request URL
https://mr.wikisource.org/wiki/%E0%A4%AA%E0%A4%BE%E0%A4%A8:%E0%A4%B0%E0%A4%BE%E0%A4%A8%E0%A4%A1%E0%A5%87_%E0%A4%87%E0%A4%82%E0%A4%97%E0%A5%8D%E0%A4%B0%E0%A4%9C%E0%A5%80-%E0%A4%AE%E0%A4%B0%E0%A4%BE%E0%A4%A0%E0%A5%80_%E0%A4%B6%E0%A4%AC%E0%A5%8D%E0%A4%A6%E0%A4%95%E0%A5%8B%E0%A4%B6_%E0%A4%96%E0%A4%82%E0%A4%A1_%E0%A4%AA%E0%A4%B9%E0%A4%BF%E0%A4%B2%E0%A4%BE_(The_Twentieth_century_English-Marathi_Dictionary_Volume_1).pdf/117
SubjectRepoBranchLines +/-
Gadget: Bump GADGET_CLASS_VERSIONmediawiki/extensions/Gadgetswmf/1.42.0-wmf.16+1 -1
Gadget: Bump GADGET_CLASS_VERSIONmediawiki/extensions/Gadgetsmaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasedancyT354434 1.42.0-wmf.16 deployment blockers
 ResolvedPRODUCTION ERRORReedyT356322 InvalidArgumentException: Unrecognized 'targets' parameter

Event Timeline

dancy created this task.Jan 31 2024, 7:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 31 2024, 7:15 PM
dancy triaged this task as Unbreak Now! priority.Jan 31 2024, 7:15 PM
dancy added a parent task: T354434: 1.42.0-wmf.16 deployment blockers.
dancy mentioned this in T354434: 1.42.0-wmf.16 deployment blockers.
dancy added a comment.Jan 31 2024, 7:23 PM

unrecognized_targets_errors.png (442×1 px, 53 KB)

kostajh subscribed.Jan 31 2024, 7:28 PM

From rEGAD27f913cc96f2: Drop RL targets definitions from module class, and validation / error code?

Reedy added a project: MediaWiki-extensions-Gadgets.Jan 31 2024, 7:36 PM
Reedy subscribed.
In T356322#9503655, @kostajh wrote:

From rEGAD27f913cc96f2: Drop RL targets definitions from module class, and validation / error code?

Yeah. Cache needs invalidating it would seem

gerritbot added a comment.Jan 31 2024, 7:37 PM

Change 994813 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Gadgets@master] Gadget: Bump GADGET_CLASS_VERSION

https://gerrit.wikimedia.org/r/994813

gerritbot added a project: Patch-For-Review.Jan 31 2024, 7:37 PM
gerritbot added a comment.Jan 31 2024, 7:53 PM

Change 994716 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/Gadgets@wmf/1.42.0-wmf.16] Gadget: Bump GADGET_CLASS_VERSION

https://gerrit.wikimedia.org/r/994716

gerritbot added a comment.Jan 31 2024, 8:30 PM

Change 994813 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Gadget: Bump GADGET_CLASS_VERSION

https://gerrit.wikimedia.org/r/994813

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 9:00 PM
gerritbot added a comment.Jan 31 2024, 9:03 PM

Change 994716 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@wmf/1.42.0-wmf.16] Gadget: Bump GADGET_CLASS_VERSION

https://gerrit.wikimedia.org/r/994716

Stashbot added a comment.Jan 31 2024, 9:03 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-31T21:03:33Z] <jforrester@deploy2002> Started scap: Backport for [[gerrit:994716|Gadget: Bump GADGET_CLASS_VERSION (T356322)]]

Stashbot added a comment.Jan 31 2024, 9:05 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-31T21:05:01Z] <jforrester@deploy2002> jforrester and reedy: Backport for [[gerrit:994716|Gadget: Bump GADGET_CLASS_VERSION (T356322)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jan 31 2024, 9:12 PM

Mentioned in SAL (#wikimedia-operations) [2024-01-31T21:12:05Z] <jforrester@deploy2002> Finished scap: Backport for [[gerrit:994716|Gadget: Bump GADGET_CLASS_VERSION (T356322)]] (duration: 08m 31s)

Jdforrester-WMF closed this task as Resolved.Jan 31 2024, 9:12 PM
Jdforrester-WMF assigned this task to Reedy.
Jdforrester-WMF subscribed.

Deployed, theoretically fixed, once the train rolls we'll know for sure.

dancy added a comment.Jan 31 2024, 9:45 PM

Thanks for the fix everyone!

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.16; 2024-01-30); removed MW-1.42-notes (1.42.0-wmf.17; 2024-02-06).Jan 31 2024, 10:00 PM
Krinkle edited projects, added Unstewarded-production-error; removed Patch-For-Review.Feb 13 2024, 4:31 PM
Krinkle moved this task from Untriaged to Jan 2024 on the Wikimedia-production-error board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL