Preference "Do not show page content below diffs" stopped working on 5 Feb 2024
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jonesey95
	Feb 5 2024, 10:07 PM

Description

Steps to replicate the issue (include links if applicable):

Make sure that "Do not show page content below diffs" is disabled in your preferences on en.WP.
Go to a typical Watchlist diff link like https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&curid=3252662&diff=1203893569&oldid=1203863882

What happens?:

Observe that the full rendered page does not display below the diff.
The text "&title=Wikipedia%253AVillage_pump_(technical)&diffonly=1" is appended after the URL in the browser's address bar

What should have happened instead?:

The full rendered page should display below the diff.
The URL should not have the extra text appended.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
This just started happening on en.WP less than one hour ago.

Details

	Subject	Repo	Branch	Lines +/-
	MobileFrontend hook should not apply outside mobile view	mediawiki/extensions/MobileFrontend	master	+5 -1
	MobileFrontend hook should not apply outside mobile view	mediawiki/extensions/MobileFrontend	wmf/1.42.0-wmf.16	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: T356717: Make it possible to show page content below diffs on mobile
T240624: Style desktop Minerva diff page to look like Special:MobileDiff

Event Timeline

Jonesey95 created this task.Feb 5 2024, 10:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2024, 10:08 PM

Jonesey95 updated the task description. (Show Details)Feb 5 2024, 10:09 PM

NightWolf1223 subscribed.Feb 5 2024, 10:12 PM

MaterialWorks subscribed.Feb 5 2024, 10:24 PM

May be caused by some change in today's backport window: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20240205T2100

Change 997598 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] MobileFrontend hook should not apply outside mobile view

https://gerrit.wikimedia.org/r/997598

gerritbot added a project: Patch-For-Review.Feb 5 2024, 10:30 PM

We enabled a change to give desktop diff view to mobile users (logged in only). It seems like enabling this feature flag invoked a hook in MobileFrontend on all skins when it should be limited to mobile.

Change 997281 had a related patch set uploaded (by Zabe; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.16] MobileFrontend hook should not apply outside mobile view

https://gerrit.wikimedia.org/r/997281

Zabe subscribed.Feb 5 2024, 10:42 PM

Change 997598 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] MobileFrontend hook should not apply outside mobile view

https://gerrit.wikimedia.org/r/997598

Change 997281 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.42.0-wmf.16] MobileFrontend hook should not apply outside mobile view

https://gerrit.wikimedia.org/r/997281

Mentioned in SAL (#wikimedia-operations) [2024-02-05T23:03:06Z] <zabe@deploy2002> Started scap: Backport for [[gerrit:997281|MobileFrontend hook should not apply outside mobile view (T356711)]]

Mentioned in SAL (#wikimedia-operations) [2024-02-05T23:04:29Z] <zabe@deploy2002> zabe: Backport for [[gerrit:997281|MobileFrontend hook should not apply outside mobile view (T356711)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Tacsipacsi mentioned this in T240624: Style desktop Minerva diff page to look like Special:MobileDiff .Feb 5 2024, 11:06 PM

Tacsipacsi subscribed.

Although it is probably superfluous, I add that the same issue happens not only on English Wikipedia, but also on Wikidata, Italian Wikipedia and probably other wikis.

Mentioned in SAL (#wikimedia-operations) [2024-02-05T23:12:25Z] <zabe@deploy2002> Finished scap: Backport for [[gerrit:997281|MobileFrontend hook should not apply outside mobile view (T356711)]] (duration: 09m 18s)

Zabe closed this task as Resolved.Feb 5 2024, 11:19 PM

Zabe assigned this task to Jdlrobson.

Jdlrobson mentioned this in T356717: Make it possible to show page content below diffs on mobile.Feb 5 2024, 11:24 PM

Novem_Linguae merged a task: T356712: mw.config.get('wgRevisionId'); / $this->getRevisionId() outputting 0 for some diffs.Feb 6 2024, 12:28 AM

Novem_Linguae subscribed.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).Feb 6 2024, 1:01 AM