Page MenuHomePhabricator
Create Task
Maniphest T356815

Migrate MediaWiki.stable_pcache to statslib
Closed, ResolvedPublic
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.stable_pcache.*.hit
  • MediaWiki.stable_pcache.*.miss*

Details

SubjectRepoBranchLines +/-
parser: Remove explicit StatsdDataFactory backward-compat logicmediawiki/coremaster+42 -59
ServiceWiring: pass StatsFactory instance to ParserCacheFactorymediawiki/coremaster+1 -1
ParserCacheFactory: Inject StatsFactory service for StatsLib metricsmediawiki/coremaster+4 -3
RevisionOutputCache: Inject StatsFactory service for StatsLib metricsmediawiki/coremaster+17 -4
ParserCache: Inject StatsFactory for StatsLib metric capturemediawiki/coremaster+31 -5
ParserCache: split metricSuffix into discrete componentsmediawiki/coremaster+40 -22
RevisionOutputCache: split metricSuffix into discrete componentsmediawiki/coremaster+12 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

lmata created this task.Feb 6 2024, 10:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2024, 10:13 PM
lmata updated the task description. (Show Details)Feb 6 2024, 10:13 PM
lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Feb 6 2024, 10:15 PM
colewhite claimed this task.Mar 1 2024, 11:54 PM
gerritbot added a comment.Mar 1 2024, 11:54 PM

Change 1007679 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] RevisionOutputCache: split metricSuffix into discrete components

https://gerrit.wikimedia.org/r/1007679

gerritbot added a project: Patch-For-Review.Mar 1 2024, 11:54 PM

Change 1007680 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] ParserCache: split metricSuffix into discrete components

https://gerrit.wikimedia.org/r/1007680

gerritbot added a comment.Mar 4 2024, 9:59 PM

Change 1008077 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] ParserCache: handle StatsFactory service

https://gerrit.wikimedia.org/r/1008077

gerritbot added a comment.Mar 4 2024, 9:59 PM

Change 1008078 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] RevisionOutputCache: handle StatsFactory service

https://gerrit.wikimedia.org/r/1008078

gerritbot added a comment.Mar 4 2024, 9:59 PM

Change 1008079 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] ParserCacheFactory: handle StatsFactory service

https://gerrit.wikimedia.org/r/1008079

gerritbot added a comment.Mar 4 2024, 9:59 PM

Change 1008080 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] ServiceWiring: pass StatsFactory instance to ParserCacheFactory

https://gerrit.wikimedia.org/r/1008080

gerritbot added a comment.Mar 7 2024, 5:36 PM

Change 1007679 merged by jenkins-bot:

[mediawiki/core@master] RevisionOutputCache: split metricSuffix into discrete components

https://gerrit.wikimedia.org/r/1007679

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 7 2024, 7:00 PM
gerritbot added a comment.Mar 11 2024, 12:46 PM

Change 1007680 merged by jenkins-bot:

[mediawiki/core@master] ParserCache: split metricSuffix into discrete components

https://gerrit.wikimedia.org/r/1007680

lmata added a project: SRE Observability (FY2023/2024-Q3).Mar 11 2024, 4:57 PM
gerritbot added a comment.Mar 15 2024, 7:10 AM

Change 1008077 merged by jenkins-bot:

[mediawiki/core@master] ParserCache: Inject StatsFactory for StatsLib metric capture

https://gerrit.wikimedia.org/r/1008077

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.23; 2024-03-19); removed MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 15 2024, 8:00 AM
gerritbot added a comment.Mar 15 2024, 10:36 AM

Change 1008078 merged by jenkins-bot:

[mediawiki/core@master] RevisionOutputCache: Inject StatsFactory service for StatsLib metrics

https://gerrit.wikimedia.org/r/1008078

gerritbot added a comment.Mar 15 2024, 11:07 AM

Change 1008079 merged by jenkins-bot:

[mediawiki/core@master] ParserCacheFactory: Inject StatsFactory service for StatsLib metrics

https://gerrit.wikimedia.org/r/1008079

gerritbot added a comment.Mar 15 2024, 11:09 AM

Change 1008080 merged by jenkins-bot:

[mediawiki/core@master] ServiceWiring: pass StatsFactory instance to ParserCacheFactory

https://gerrit.wikimedia.org/r/1008080

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2024, 11:30 AM
gerritbot added a comment.Mar 26 2024, 10:53 PM

Change #1011283 had a related patch set uploaded (by Cwhite; author: Derick Alangi):

[mediawiki/core@master] parser: Remove explicit StatsdDataFactory backward-compat logic

https://gerrit.wikimedia.org/r/1011283

gerritbot added a project: Patch-For-Review.Mar 26 2024, 10:54 PM
gerritbot added a comment.Mar 27 2024, 12:59 AM

Change #1011283 merged by jenkins-bot:

[mediawiki/core@master] parser: Remove explicit StatsdDataFactory backward-compat logic

https://gerrit.wikimedia.org/r/1011283

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.25; 2024-04-02); removed MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 27 2024, 1:00 AM
colewhite closed this task as Resolved.Apr 3 2024, 10:46 PM
lmata moved this task from Inbox to Done on the SRE Observability (FY2023/2024-Q3) board.Apr 4 2024, 6:12 PM
colewhite merged a task: T359272: Migrate MediaWiki.stable_pcache to statslib.Apr 4 2024, 10:11 PM
colewhite merged a task: T359368: Migrate MediaWiki.pcache.* to statslib.Apr 26 2024, 6:00 PM
colewhite merged a task: T359390: Migrate MediaWiki.parsoid_pcache.*.reason.*.rate to statslib.Apr 26 2024, 6:11 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2024, 6:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL