Maniphest T357001

Standardize message and time limit options for all scripts
Open, LowPublic
Actions

Assigned To

None

Authored By

	Ejegg
	Feb 8 2024, 2:31 PM

Tags

Referenced Files

None

Subscribers

Description

All the SmashPig maintenance scripts, drush scripts, and API actions that read from queues should use

--time-limit for the time limit in seconds, and
--message-limit for the maximum number of messages to process.

Details

	Subject	Repo	Branch	Lines +/-
	Update parameter names for ty drush job	wikimedia/fundraising/crm	master	+12 -12
	Rename donation queue consumer params	wikimedia/fundraising/crm	master	+28 -30
	Change --max-messages to --message-limit	wikimedia/fundraising/SmashPig	master	+12 -12

Customize query in gerrit

Related Objects

Mentioned Here: T357470: replace our drush scripts with WMFQueue.consume api

Event Timeline

Ejegg created this task.Feb 8 2024, 2:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2024, 2:31 PM

Change 998936 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/SmashPig@master] Change --max-messages to --message-limit

https://gerrit.wikimedia.org/r/998936

gerritbot added a project: Patch-For-Review.Feb 8 2024, 2:40 PM

Ejegg updated the task description. (Show Details)Feb 8 2024, 3:04 PM

Change 998936 merged by Ejegg:

[wikimedia/fundraising/SmashPig@master] Change --max-messages to --message-limit

https://gerrit.wikimedia.org/r/998936

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 6:30 PM

greg triaged this task as Low priority.Feb 8 2024, 10:33 PM

greg moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.

Change 999100 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Rename donation queue consumer params

https://gerrit.wikimedia.org/r/999100

gerritbot added a project: Patch-For-Review.Feb 8 2024, 10:36 PM

Change 999130 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Update parameter names for ty drush job

https://gerrit.wikimedia.org/r/999130

Change 999100 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Rename donation queue consumer params

https://gerrit.wikimedia.org/r/999100

Change 999130 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Update parameter names for ty drush job

https://gerrit.wikimedia.org/r/999130

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2024, 12:30 AM

AKanji-WMF moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Feb 12 2024, 9:33 PM

this is also in progress in the work eileen is doing to move things onto cv

https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/dev/+/1016865

civi parts are handled in T357470: replace our drush scripts with WMFQueue.consume api