Page MenuHomePhabricator
Create Task
Maniphest T357589

[Regression] Wikitables has unwanted border spacing on mobile
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
Msz2001
Feb 14 2024, 10:05 PM
Tags
Referenced Files
F42029089: screenshot 539.png
Feb 21 2024, 10:17 PM
F42029088: screenshot 540.png
Feb 21 2024, 10:17 PM
F41937709: screenshot 535.png
Feb 17 2024, 1:43 AM
F41937708: screenshot 534.png
Feb 17 2024, 1:43 AM
F41901855: image.png
Feb 14 2024, 10:05 PM
F41901852: image.png
Feb 14 2024, 10:05 PM
Subscribers
Aklapper
DLynch
Edtadros
Jdlrobson
Msz2001
ovasileva

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The tables have border spacing.

What should have happened instead?:
The tables should not have border spacing, just like on desktop, where there's no border spacing.

Software version (skip for WMF-hosted wikis like Wikipedia): 1.42 wmf.18

Other information (browser name/version, screenshots, etc.):
Does not affect wmf.17 (like https://en.m.wikipedia.org/wiki/Special:CentralAuth/Msz2001)

On mobile (the mediawiki.org page):

image.png (618×791 px, 68 KB)

On desktop (the mediawiki.org page):

image.png (501×735 px, 59 KB)

QA Results - Beta

ACStatusDetails
1✅T357589#9552772

QA Results - Prod

ACStatusDetails
1✅T357589#9565467

Details

SubjectRepoBranchLines +/-
Add border-collapse to wikitablemediawiki/skins/MinervaNeuewmf/1.42.0-wmf.18+1 -0
Add border-collapse to wikitablemediawiki/skins/MinervaNeuemaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Msz2001 created this task.Feb 14 2024, 10:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2024, 10:05 PM
Izno added a parent task: T205341: Replace reset.css rules with ResourceLoaderSkinModule `normalize` feature.Feb 14 2024, 10:06 PM
Msz2001 mentioned this in T354436: 1.42.0-wmf.18 deployment blockers.Feb 14 2024, 10:06 PM
thcipriani added a project: Web-Team-Backlog.Feb 15 2024, 4:10 PM
Jdlrobson moved this task from Incoming to FY2023-24 Q3 Sprint 4 on the Web-Team-Backlog board.Feb 15 2024, 5:59 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 4); removed Web-Team-Backlog.
DLynch added subscribers: Jdlrobson, DLynch.Feb 15 2024, 6:03 PM

@Jdlrobson Specifically it's fallout from https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/995137 removing the generic border-collapse from all minerva tables.

gerritbot added a comment.Feb 15 2024, 6:06 PM

Change 1003807 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/skins/MinervaNeue@master] Add border-collpase to wikitable

https://gerrit.wikimedia.org/r/1003807

gerritbot added a project: Patch-For-Review.Feb 15 2024, 6:06 PM
ovasileva triaged this task as Medium priority.Feb 15 2024, 6:07 PM
Jdlrobson added a comment.Feb 15 2024, 6:09 PM

@DLynch would it make sense to add this into the core styles? I assume Vector has a similar rule?

Jdlrobson added a comment.Feb 15 2024, 6:10 PM

Specifically: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.tables.less

ovasileva set the point value for this task to 1.Feb 15 2024, 6:11 PM
ovasileva moved this task from Incoming to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 4) board.
DLynch added a comment.Feb 15 2024, 6:11 PM

It's already in that file, so I assume that the issue is something like that not actually being loaded on mobile. (And unifying all that would be a much bigger change...)

Jdlrobson added a comment.Feb 15 2024, 6:27 PM

Ack! Makes sense! Thanks!

gerritbot added a comment.Feb 15 2024, 6:30 PM

Change 1003485 had a related patch set uploaded (by Jdlrobson; author: DLynch):

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.18] Add border-collapse to wikitable

https://gerrit.wikimedia.org/r/1003485

gerritbot added a comment.Feb 15 2024, 6:50 PM

Change 1003807 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Add border-collapse to wikitable

https://gerrit.wikimedia.org/r/1003807

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 15 2024, 8:00 PM
gerritbot added a comment.Feb 15 2024, 11:38 PM

Change 1003485 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.42.0-wmf.18] Add border-collapse to wikitable

https://gerrit.wikimedia.org/r/1003485

Stashbot added a comment.Feb 15 2024, 11:38 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T23:38:38Z] <thcipriani@deploy2002> Started scap: Backport for [[gerrit:1003485|Add border-collapse to wikitable (T357589)]]

Stashbot added a comment.Feb 15 2024, 11:40 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T23:40:07Z] <thcipriani@deploy2002> thcipriani and jdlrobson: Backport for [[gerrit:1003485|Add border-collapse to wikitable (T357589)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Jdlrobson assigned this task to Edtadros.Feb 15 2024, 11:42 PM
Jdlrobson edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Unplanned-Sprint-Work; removed Web-Team-Backlog (FY2023-24 Q3 Sprint 4).
Jdlrobson added a project: Regression.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.
Stashbot added a comment.Feb 15 2024, 11:50 PM

Mentioned in SAL (#wikimedia-operations) [2024-02-15T23:50:10Z] <thcipriani@deploy2002> Finished scap: Backport for [[gerrit:1003485|Add border-collapse to wikitable (T357589)]] (duration: 11m 31s)

Maintenance_bot removed a project: Patch-For-Review.Feb 16 2024, 12:31 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.18; 2024-02-13); removed MW-1.42-notes (1.42.0-wmf.19; 2024-02-20).Feb 16 2024, 5:01 AM
Edtadros removed Edtadros as the assignee of this task.Feb 17 2024, 1:43 AM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Use mobile version
Navigate to a page using wikitable, eg. https://m.mediawiki.org/wiki/Help:Tables#Wiki_table_markup_summary or https://meta.m.wikimedia.org/wiki/Special:CentralAuth/Msz2001
✅ AC1: The tables should not have border spacing, just like on desktop, where there's no border spacing.

screenshot 534.png (702×1 px, 151 KB)

screenshot 535.png (818×1 px, 147 KB)

Edtadros updated the task description. (Show Details)Feb 17 2024, 1:44 AM
ovasileva closed this task as Resolved.Feb 19 2024, 12:14 PM
ovasileva claimed this task.
ovasileva subscribed.

Looks good, resolving.

Edtadros added a comment.EditedFeb 21 2024, 10:17 PM

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Use mobile version
Navigate to a page using wikitable, eg. https://m.mediawiki.org/wiki/Help:Tables#Wiki_table_markup_summary or https://meta.m.wikimedia.org/wiki/Special:CentralAuth/Msz2001
✅ AC1: The tables should not have border spacing, just like on desktop, where there's no border spacing.

screenshot 540.png (844×391 px, 65 KB)

screenshot 539.png (846×392 px, 113 KB)

Edtadros added a project: Verified.Feb 21 2024, 10:18 PM
Edtadros updated the task description. (Show Details)
Edtadros mentioned this in T356225: Verify 1.42.0-wmf.18 deployment.Feb 22 2024, 10:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL