NOTE: The scope of this ticket is to make sure that the editor is readable, NOT to switch it over to the night mode theme.
NOTE: Jon to add QA steps for specific elements we care about on https://it.m.wikipedia.org/wiki/Spain_(gruppo_musicale)?minervanightmode=1#/editor/0
This was flagged in QA for T356427. The spike T353663 has not clarified what we should do about OOUI but this is arguably the most high profile bug relating to OOUI integration that requires a fix
Steps to replicate the issue (include links if applicable):
- Visit https://en.m.wikipedia.org/wiki/Dog?minervanightmode=1
- Click edit
- Make a change click preview
- Go back
- Switch to Visual editor mode
What happens?:
The mobile editor consists of MobileFrontend components and OOUI components. This means that the overlay gets both night and light mode themed elements.
What should have happened instead?:
A good short term fix would be to target the problematic elements in a skin style via CSS targeting following elements
.skin-night-mode-clientpref-1 .ve-ui-overlay-global-mobile {
.oo-ui-toolbar-popups,
.oo-ui-textInputWidget .oo-ui-inputWidget-input { background; color; }
.oo-ui-window-head {
.oo-ui-buttonElement-button { filter: invert(1); }
}
}
.Expected results from short-term fix:
- All of the wikitext editor appears in night mode. All elements are functional and accessible.
- The OOUI portions of VE appear in day mode. All elements are functional and accessible. The remainder of VE appears in night mode. All elements are functional and accessible
Software version (skip for WMF-hosted wikis like Wikipedia):
Other information (browser name/version, screenshots, etc.):
QA Results - Beta
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T358528#9614185 |
QA Results - Prod
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T358528#9647629 |
| 2 | ✅ | T358528#9647629 |
