Update the GlobalBlockingLinkBuilder service for global account blocks
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 28 2024, 9:04 PM

Description

The GlobalBlockingLinkBuilder needs to be updated to use a different message for the link to Special:GlobalBlock depending on the value of the config added in T356923: Create a configuration value to control whether global account blocks are enabled.

Acceptance criteria

The link text to Special:GlobalBlock uses the globalblocking-goto-block-new message key if the config added in T356923: Create a configuration value to control whether global account blocks are enabled is set to true (otherwise uses globalblocking-goto-block)

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T358725 here

Details

	Subject	Repo	Branch	Lines +/-
	Update GlobalBlockingLinkBuilder service for global account blocks	mediawiki/extensions/GlobalBlocking	master	+36 -10

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 Update features for temporary accounts
Open	None	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Open	None	T19929 CentralAuth account locks should trigger global autoblocks
Duplicate	None	T340275 Allow GlobalBlocking to block temporary accounts
Open	Skizzerz	T17294 Allow blocking of global accounts
Open	None	T358777 Rename messages with the '-new' suffix to remove this suffix
Open	None	T358776 Remove old versions of GlobalBlocking i18n messages
Open	None	T358773 Remove the global accounts block configuration flag
Open	None	T356924 Deploy global account blocks to WMF wikis
Open	None	T356926 Add support to block global accounts using the globalblock API
Open	None	T356929 Allow SpecialRemoveGlobalBlock to remove a global block on an account
Resolved	Dreamy_Jazz	T356931 Support modifying the status of global blocks on accounts using Special:GlobalBlockStatus
Open	None	T356932 Allow Special:GlobalBlockList to show global blocks for accounts
Open	Dreamy_Jazz	T356934 Allow a user to perform global blocks on accounts using Special:GlobalBlock
Open	None	T356935 The 'globalblocks' API should support listing global blocks for accounts
Resolved	Dreamy_Jazz	T356936 Update GlobalBlocking services to support global block on accounts
Resolved	Dreamy_Jazz	T358725 Update the GlobalBlockingLinkBuilder service for global account blocks
Resolved	Dreamy_Jazz	T356923 Create a configuration value to control whether global account blocks are enabled
Resolved	Dreamy_Jazz	T356925 Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts
Resolved	Dreamy_Jazz	T357385 Refactor the GlobalBlocking utility class into services
Resolved	Dreamy_Jazz	T357399 Create GlobalBlockingConnectionProvider
Resolved	Dreamy_Jazz	T357443 Create GlobalBlockingBlockPurger service
Resolved	Dreamy_Jazz	T357506 Create GlobalBlockLocalStatusLookup service
Resolved	Dreamy_Jazz	T357675 Create GlobalBlockLookup service
Resolved	Dreamy_Jazz	T357925 Create the GlobalBlockManager service

Event Timeline

Dreamy_Jazz created this task.Feb 28 2024, 9:04 PM

Dreamy_Jazz added a subtask: T356923: Create a configuration value to control whether global account blocks are enabled.

Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 29 2024, 9:19 PM

Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 29 2024, 10:18 PM

Change 1007731 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockingLinkBuilder service for global account blocks

https://gerrit.wikimedia.org/r/1007731

gerritbot added a project: Patch-For-Review.Feb 29 2024, 10:40 PM

Dreamy_Jazz updated the task description. (Show Details)Feb 29 2024, 10:41 PM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Dreamy_Jazz added a subtask: T356925: Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts.Feb 29 2024, 10:52 PM

Dreamy_Jazz added a subtask: T357385: Refactor the GlobalBlocking utility class into services.

Change 1007731 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockingLinkBuilder service for global account blocks

https://gerrit.wikimedia.org/r/1007731

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2024, 11:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 3 2024, 1:00 PM

Dreamy_Jazz moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Mar 4 2024, 11:38 AM

Suggested QA steps:

Install GlobalBlocking, if required
Set $wgGlobalBlockingAllowGlobalAccountBlocks = false; in your LocalSettings.php
Load Special:GlobalBlockList while logged into an account with the steward group and verify the subtitle links look like the following:

Remove the code added in line 2 from LocalSettings.php
Reload the page loaded in step 3 and verify the subtitle links have now changed to the following:

@Dreamy_Jazz When $wgGlobalBlockingAllowGlobalAccountBlocks = false; is loaded to your LocalSettings.php. you will see "Globally block an IP address". When it is commented out, you will see "Globally block a user" as seen in the .webm. This will be moved to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Local: commit 5bdc5ba4b28f6a82cf395cc9d0f3c350c8ed760f, Mon Mar 4 16:55:15 2024; GlobalBlocking: commit 21786b8b2e53b54d0638338c5317943dabfb3364, Mon Mar 4 11:47:57 2024
OS: macOS Sonoma 14.2.1
Browser: Chrome 122, Firefox 123, Safari 17.3, Edge 122
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/w/index.php?title=Special:GlobalBlockList

✅AC1: https://phabricator.wikimedia.org/T358725

Firefox	Safari	Edge

GMikesell-WMF updated the task description. (Show Details)Mar 4 2024, 10:03 PM

GMikesell-WMF moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Dreamy_Jazz closed this task as Resolved.Mar 5 2024, 12:04 PM

Dreamy_Jazz closed subtask T356925: Update or duplicate GlobalBlocking messages to allow staged deployment of blocking accounts as Resolved.Mar 7 2024, 5:27 PM

	F42396929: T358725_GB_Allow_Steward.webm
	Mar 4 2024, 10:00 PM

	F42389971: image.png
	Mar 4 2024, 11:43 AM

	F42389986: image.png
	Mar 4 2024, 11:43 AM

Update the GlobalBlockingLinkBuilder service for global account blocksClosed, ResolvedPublic1 Estimated Story PointsActions