tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4814

@OTichonova Experimental #114 is kicked off for design review on this one.

I was able to save some time by reusing the system half sheet modal component for this one. I wasn't sure what you wanted to do for iPad, but I found an easy way to use popovers for them (source: https://developer.apple.com/videos/play/wwdc2021/10063/?time=605). Let me know what you think!

Hi @Tsevener, thank you for the screenshots for iPad. It is a pretty cool use of popovers, looks good!

Small detail:

1. The designs have a slightly different sf symbol -> photo.badge.plus

@OTichonova ah good catch, sorry I missed that! Here are some screenshots of the latest:

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4814

Can be tested on the latest Wikipedia Beta version 7.5.0 (3509)

Working for me on 7.5.0 (3512)

For this requirement:
Appears the first time someone opens that app after the feature has been added.

I'm seeing this behavior for these situations:
A) On initial use after reinstall now, no announcement
B) After minimizing and reopening app, it does not appear on Explore feed immediately, it appears after I navigate away and then back to Explore feed.
C) After another reinstall, on initial use, no announcement. After fully closing and reopening, it appears immediately on Explore feed on open

@Tsevener is that as expected? This is ok, but it would be more ideal to have it display on the initial explore feed for A and B as well.

@HNordeenWMF Yeah it's a little weird, I may be able to improve it. The current logic I have in the code is: upon Explore feed appearance (this includes tapping to show the tab, or landing on it after first launch, but NOT considering foregrounding after backgrounding the app), if the suggested edits card is in the Explore feed, show the modal, if there isn't already a modal displaying. So it will appear to fail task requirements in these situations:

1. I notice sometimes I see a "Sync is enabled on your account" modal that pops up after the app logs the user in. The system rejects new modals presenting from the Explore feed if it's already presenting a modal. I think we should keep this so we avoid any double-modal situation.
2. Sometimes it takes time for the suggested edits card to appear in the Explore feed. This is because behind-the-scenes we are checking their edit count, blocked status, and if their primary app language wiki has image recommendations. These calls can take several seconds, so at the time of Explore feed appearance we aren't sure yet whether the user qualifies to see the feature. I could try to present it when the card is inserted, but I wasn't sure if we wanted to potentially interrupt what they were doing in the Explore feed if it's been a while.
3. I am not attempting to present the modal upon foregrounding. I should be able to easily add this one.

Let me know what you think! Thanks.

1. I notice sometimes I see a "Sync is enabled on your account" modal that pops up after the app logs the user in. The system rejects new modals presenting from the Explore feed if it's already presenting a modal. I think we should keep this so we avoid any double-modal situation.

Agree! I was closing the Sync dialog each time so that must be why it was not showing on initial launch. After closing the dialog and navigating away and back to explore feed, I see the announcement.

2. Sometimes it takes time for the suggested edits card to appear in the Explore feed. This is because behind-the-scenes we are checking their edit count, blocked status, and if their primary app language wiki has image recommendations. These calls can take several seconds, so at the time of Explore feed appearance we aren't sure yet whether the user qualifies to see the feature. I could try to present it when the card is inserted, but I wasn't sure if we wanted to potentially interrupt what they were doing in the Explore feed if it's been a while.

I agree we don't want to interrupt.

3. I am not attempting to present the modal upon foregrounding. I should be able to easily add this one.

(That's what that is called, now I'll know the difference open vs foreground, close vs background!) That would be nice to add if there's capacity, for folks that never fully close apps. I am assuming this would present the modal once to people on first foregrounding it after the feature has been added, or first opening the app after it was closed but never both.

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4833

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4833

Can be tested in Wikipedia 7.5.0 (3546)

Working for me on 7.5.0 (3525)

Looks great!