Page MenuHomePhabricator

[S] Error/success handling for Image Recs
Closed, ResolvedPublic

Assigned To
Authored By
HNordeenWMF
Mar 1 2024, 11:15 PM
Referenced Files
F49673689: IMG_0627.PNG
May 1 2024, 6:45 PM
F49673670: IMG_5996.PNG
May 1 2024, 6:45 PM
F49673617: IMG_0626.PNG
May 1 2024, 6:45 PM
F49673598: IMG_5995.PNG
May 1 2024, 6:45 PM
F49673501: IMG_AE80A40FFCCC-1.jpeg
May 1 2024, 6:45 PM
F49673442: IMG_5994.PNG
May 1 2024, 6:45 PM
F49672931: IMG_5994.PNG
May 1 2024, 6:45 PM
F49672636: IMG_0625.PNG
May 1 2024, 6:45 PM

Description

We should communicate the user:

  • When their edit is published:

Screenshot 2024-03-05 at 12.04.00.png (102×492 px, 14 KB)

  • When the edit publishing fails:

Copy and design see Olga's comment

  • No connection:

Copy and design see Olga's comment

Test Notes

Can be tested on Wikipedia 7.5.0 (3525)

Event Timeline

Mazevedo removed subscribers: Jarrod_Baniqued, ldelench_wmf.

Hi @OTichonova! Can we get copy/designs for when the publishing fails and there is no connection?

Can we get copy/designs for when the publishing fails and there is no connection?

Hi @Mazevedo, here are some toasts (top of page) and error messages. Let me know if there is any other specific cases you need designs for.

Something fails -> unable to publish editNo internet connectionSever errorError state, with no fallback
Toast 1.png (87×395 px, 10 KB)
{F42466503}
Error.png (667×375 px, 65 KB)
Unable to load page with no fallback.png (667×375 px, 15 KB)
JTannerWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.
Tsevener renamed this task from [S] Error/success handling for Image Recs to Error/success handling for Image Recs.Mar 5 2024, 8:56 PM
Tsevener renamed this task from Error/success handling for Image Recs to [S] Error/success handling for Image Recs.Apr 25 2024, 5:02 PM
ABorbaWMF subscribed.

Testing on 7.5.0 (3525)

I found a few places where this was not quite working correctly.

Loss of internet connection before tapping Add an Image

iPhoneiPad
IMG_5993.PNG (2×1 px, 95 KB)
IMG_0625.PNG (2×1 px, 138 KB)
IC error displayedNo IC error

After restoring internet connection on Add an Image screen

iPhoneiPad
IMG_5994.PNG (2×1 px, 737 KB)
IMG_0625.PNG (2×1 px, 138 KB)
After tapping try againno try again available

Loss of internet connection before tapping yes

iphoneiPad
IMG_5994.PNG (2×1 px, 737 KB)
IMG_AE80A40FFCCC-1.jpeg (2×1 px, 922 KB)
tap yestap yes
IMG_5995.PNG (2×1 px, 405 KB)
IMG_0626.PNG (2×1 px, 219 KB)
Blank screenblank screen
IMG_5996.PNG (2×1 px, 50 KB)
IMG_0627.PNG (2×1 px, 59 KB)

Note: We probably need to make sure we have an internet connection error available on each step of the image rec flow.

@ABorbaWMF Thanks! I'm working on adding the no internet connection banner into the "Add image details" and "Preview" screens. I cannot reproduce your iPad "No IC error" issue - can you send me a screencast for that one?

@Tsevener Sorry I was abbreviating 'internet connection' error. I don't see anything on those screens that says no connection or the like.

HNordeenWMF claimed this task.
HNordeenWMF changed the task status from Unknown Status to Resolved.May 7 2024, 10:21 PM