Maniphest T358950

Local interlanguage links don’t work with Parsoid read views
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to reproduce

Open https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Karbantart%C3%B3m%C5%B1hely&useparsoid=0.
Notice that there are a couple of interlanguage links in the language selector / sidebar.
Open https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Karbantart%C3%B3m%C5%B1hely&useparsoid=1.

Actual result

Notice that there are no interlanguage links in the language selector / sidebar.

Expected result

Notice that the same interlanguage links continue to appear.

Other information

Wikidata-based interlanguage links continue to appear using Parsoid, which both makes the issue less severe and made it more challenging to find out the root cause (I experienced it first in an article that has both Wikidata-based and local interlanguage links, so I only saw that the Wikidata-based one overrides the local one).

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Open		None	T297840 Populate ParserCache with Parsoid output as a post-edit hook
Open		None	T310511 Metadata comparison testing between Parsoid and the legacy parser
Open		None	T310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
Open	BUG REPORT	Jgiannelos	T358950 Local interlanguage links don’t work with Parsoid read views

Event Timeline

Tacsipacsi created this task.Mar 2 2024, 12:03 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptMar 2 2024, 12:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The simple way to reproduce is using user page: https://en.wikipedia.org/wiki/User:Jimbo_Wales?useparsoid=1 - until we resolved T168792, interlanguage links of user pages are still stored locally.

Similar to T351931, this may just be another case where Parsoid isn't adding these links to metadata?

Note: please make sure local interlanguage link will override those provided by Wikibase amd Cognate.

In T358950#9593315, @ssastry wrote:

Similar to T351931, this may just be another case where Parsoid isn't adding these links to metadata?

The method just below the one touched by the patch for T351931 contains a comment saying

TODO: […] when calling ContentMetadataCollector::addLanguageLink() here (which we should eventualy be doing)

so yeah, that may be the culprit.

MSantos edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.Mar 7 2024, 3:26 PM

MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Yeah, it's "just" missing metadata -- I wasn't aware that interlanguage links were actually used in production (I thought they were /replaced/ by wikidata, instead of just /supplementing/ wikidata) so I didn't prioritize this work. But it should be fixed as part of the Parsoid metadata work which @Jgiannelos is doing.

cscott added a parent task: T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata.Mar 7 2024, 3:28 PM

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Apr 11 2024, 2:29 PM

MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.

ihurbain claimed this task.Mon, Apr 29, 9:22 AM

ihurbain removed ihurbain as the assignee of this task.Mon, Apr 29, 2:06 PM

ihurbain subscribed.

cscott moved this task from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.Mon, Apr 29, 3:15 PM

MSantos moved this task from Current Deploy Target to In Progress on the Content-Transform-Team-WIP board.Mon, Apr 29, 3:21 PM

Jgiannelos claimed this task.Mon, Apr 29, 3:22 PM

RheingoldRiver subscribed.Fri, May 3, 7:01 PM