Page MenuHomePhabricator
Create Task
Maniphest T359205

Deployment Ticket - Linting Rule for Template Style Fixes
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Per T358238, we are adding a new lint rule to the Parsoid extension. This lint rule will address the issue of defining background colors without corresponding text colors, which has been identified as an antipattern.
This is the deployment ticket to track this and follow up work.

Success Criteria

Details

SubjectRepoBranchLines +/-
Add inline background colormediawiki/extensions/Linterwmf/1.42.0-wmf.22+11 -0
Add inline background colormediawiki/extensions/Lintermaster+11 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenJdrewniakT341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
 OpenJdrewniakT341632 [EPIC] Palette customizations and dark mode
 OpenNoneT354835 [epic] Release night mode as a beta feature on desktop and mobile
 OpenNoneT354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
 OpenNoneT354837 [Night mode] Page background appears in night mode on desktop
OpenNoneT354838 [Night mode] Page background appears in night mode on mobile
 ResolvedJScherer-WMFT356825 Implement the new night mode color palette in Minerva
 ResolvedovasilevaT357759 Deploy night mode on the minerva skin on test wiki
 ResolvedSpikeSToyofuku-WMFT357077 [Spike] Explore different options for code sharing of page-specific configuration between Minerva and Vector
 OpenNoneT354842 [Night mode] All global navigation open by default appear in night mode on desktop
 OpenJdrewniakT354889 Vector 2022 should get night theme
 ResolvedJScherer-WMFT354891 [Design] Implement the dark mode color palette and switch LESS variables in Vector to use it
 OpenNoneT354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
 OpenNoneT356344 [Night mode] Templates can be fixed by editors when necessary for night mode
 ResolvedovasilevaT357998 Address color contrast issues in .wikitable
 ResolvedVolker_ET334790 tokens: Implement new static layout background-color tokens
 OpenNoneT358387 [EPIC] Ensure all template text is readable in night mode: Fix all templates using background without color
 ResolvedJdlrobsonT356899 [Spike] Explore automatic night mode fixes with content transform team
 DeclinedJdlrobsonT358239 Automatic Correction of Template and Inline Styles
 ResolvedSToyofuku-WMFT358240 [Spike 4hours] Performance Impact Assessment for Night Mode Style Correction
 OpenovasilevaT356341 [Night Mode] I want to opt into or out of night mode on mobile
 ResolvedovasilevaT355065 Set up feature flag and menu for night mode on desktop
 ResolvedovasilevaT357707 Re-order Vector preferences - night mode should be above limited width
 ResolvedovasilevaT355118 Set up feature flag for night mode on mobile
 ResolvedovasilevaT355705 Allow pages to not appear in night mode
ResolvedFeatureNoneT328850 Minerva/Vector: Dark mode toggle needs to be tri state
 OpenNoneT362923 Dark mode toggle needs to be tri state in Extension:DarkMode
 ResolvedovasilevaT356653 Show a toast notification on page load for night mode when the setting doesn't take effect in Minerva
 ResolvedovasilevaT358811 Set Minerva default to day mode
 OpenNoneT361047 Minerva Night Mode launch notifications
 ResolvedovasilevaT359152 Deploy initial version of night mode to pilot wikis on the mobile website for testing
 ResolvedJdlrobsonT358238 Implement Linting Rule for Template Style Fixes
 ResolvedJdlrobsonT359205 Deployment Ticket - Linting Rule for Template Style Fixes
 ResolvedNoneT358241 Document new night mode linting rules

Event Timeline

KSarabia-WMF created this task.Mar 5 2024, 6:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2024, 6:03 PM
KSarabia-WMF added a parent task: T358238: Implement Linting Rule for Template Style Fixes.Mar 5 2024, 6:04 PM
ovasileva triaged this task as High priority.Mar 7 2024, 2:37 PM
ovasileva edited projects, added Web-Team-Backlog (FY2023-24 Q3 Sprint 5); removed Web-Team-Backlog.
ovasileva updated the task description. (Show Details)Mar 7 2024, 5:24 PM
Jdlrobson renamed this task from Deployment Ticket - Implement Linting Rule for Template Style Fixes to Deployment Ticket - Linting Rule for Template Style Fixes.Mar 7 2024, 5:54 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Mar 7 2024, 5:55 PM

Change 1007448 had a related patch set uploaded (by Jdlrobson; author: Kimberly Sarabia):

[mediawiki/extensions/Linter@master] Add inline background color

https://gerrit.wikimedia.org/r/1007448

gerritbot added a project: Patch-For-Review.Mar 7 2024, 5:55 PM
ovasileva set the point value for this task to 1.Mar 7 2024, 6:35 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Jdlrobson moved this task from Backlog to Night mode (mobile) on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:10 AM
Jdlrobson added a comment.Mar 8 2024, 7:06 PM

The rule has been documented at https://www.mediawiki.org/wiki/Help:Lint_errors/night-mode-unaware-background-color

Jdlrobson claimed this task.Mar 9 2024, 12:46 AM
Jdlrobson mentioned this in T358238: Implement Linting Rule for Template Style Fixes.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Mar 11 2024, 7:52 PM
Jdlrobson updated the task description. (Show Details)Mar 11 2024, 10:13 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Mar 12 2024, 11:02 PM
Jdlrobson mentioned this in T358241: Document new night mode linting rules.Mar 12 2024, 11:36 PM
Jdlrobson added a subtask: T358241: Document new night mode linting rules.
gerritbot added a comment.Mar 13 2024, 7:35 PM

Change 1007448 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Add inline background color

https://gerrit.wikimedia.org/r/1007448

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 13 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 8:30 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.Mar 13 2024, 10:34 PM
Jdlrobson updated the task description. (Show Details)Mar 13 2024, 10:39 PM
Jdlrobson closed subtask T358241: Document new night mode linting rules as Resolved.Mar 14 2024, 4:39 PM
Jdlrobson mentioned this in T360132: QA: Night mode linting rule.Mar 14 2024, 5:09 PM

Announced here: https://en.wikipedia.org/wiki/Wikipedia_talk:Linter#Night_mode:_New_lint_rule
QA task here: T360132

Jdlrobson closed this task as Resolved.Mar 14 2024, 5:09 PM
Jdlrobson updated the task description. (Show Details)
cscott subscribed.Mar 20 2024, 7:15 PM

These patches might have caused T360565.

gerritbot added a comment.Mar 20 2024, 7:29 PM

Change 1012781 had a related patch set uploaded (by Zabe; author: Kimberly Sarabia):

[mediawiki/extensions/Linter@wmf/1.42.0-wmf.22] Add inline background color

https://gerrit.wikimedia.org/r/1012781

gerritbot added a project: Patch-For-Review.Mar 20 2024, 7:29 PM
gerritbot added a comment.Mar 20 2024, 8:09 PM

Change 1012781 merged by jenkins-bot:

[mediawiki/extensions/Linter@wmf/1.42.0-wmf.22] Add inline background color

https://gerrit.wikimedia.org/r/1012781

Stashbot added a comment.Mar 20 2024, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-20T20:20:01Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]]

Stashbot mentioned this in T360565: MediaWiki\Linter\MissingCategoryException: Cannot find id for 'night-mode-unaware-background-color'.Mar 20 2024, 8:20 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 20 2024, 8:30 PM
Stashbot added a comment.Mar 20 2024, 8:45 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-20T20:45:34Z] <catrope@deploy2002> catrope and zabe: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 20 2024, 9:02 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-20T21:02:59Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]] (duration: 42m 57s)

Jonesey95 mentioned this in T360793: Linter help link for night-mode-unaware-background-color goes to empty page.Mar 22 2024, 4:14 PM
Sdkb subscribed.Mar 22 2024, 4:17 PM

This task is causing an issue; see here. Please roll back deployment until you have addressed stuff like this.

Jdlrobson added a project: Verified.Apr 1 2024, 12:50 AM
In T359205#9654539, @Sdkb wrote:

This task is causing an issue; see here. Please roll back deployment until you have addressed stuff like this.

This has since been addressed as part of T360796.

Edtadros mentioned this in T359679: Verify 1.42.0-wmf.23 deployment.Apr 3 2024, 9:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL