Page MenuHomePhabricator
Create Task
Maniphest T360026

Skip and then fix flapping reuseRefs tests
Closed, ResolvedPublic
Actions

Description

This test is causing crashes in unrelated repos. Normally, we immediately skip tests which do this, and work to stabilize the test off-line.

00:06:10.485   1) Re-using refs in Visual Editor
00:06:10.485        should display existing references in the Cite re-use dialog:
00:06:10.485      CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is not visible:
00:06:10.485 
00:06:10.485 `<span class="oo-ui-tool-title">Re-use</span>`
00:06:10.485 
00:06:10.485 This element `<span.oo-ui-tool-title>` is not visible because its parent `<div.oo-ui-toolGroup-tools.oo-ui-clippableElement-clippable.oo-ui-floatableElement-floatable.oo-ui-popupToolGroup-tools.oo-ui-listToolGroup-tools.oo-ui-toolGroup-enabled-tools>` has CSS property: `display: none`

Details

SubjectRepoBranchLines +/-
[Cypress] Unskip testsmediawiki/extensions/Citemaster+2 -2
[Cypress] Retry toolbar clicks to open submenumediawiki/extensions/Citemaster+15 -1
[Cypress] Wait for VE to loadmediawiki/extensions/Citemaster+1 -0
Skip tests causing trouble in the wildmediawiki/extensions/Citemaster+2 -2
Try more specific CSS selectors for clicks in browser testsmediawiki/extensions/Citemaster+3 -4
[Cypress] Increase default timeoutmediawiki/extensions/Citemaster+1 -0
[Cypress] Check toolbar state to wait for VEmediawiki/extensions/Citemaster+7 -1
Skip reuseRefs test until we can debugmediawiki/extensions/Citemaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight triaged this task as Medium priority.Mar 13 2024, 12:51 PM
awight created this task.
gerritbot added a comment.Mar 13 2024, 12:52 PM

Change 1010886 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Skip reuseRefs test until we can debug

https://gerrit.wikimedia.org/r/1010886

gerritbot added a project: Patch-For-Review.Mar 13 2024, 12:52 PM
awight renamed this task from Fix or skip flapping reuseRefs tests to Skip and then fix flapping reuseRefs tests.Mar 13 2024, 12:53 PM
Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2024-03-13.Mar 13 2024, 2:06 PM
thiemowmde mentioned this in T356858: Create a first set of end to end test for reference re-use in VE.Mar 14 2024, 8:55 AM
thiemowmde added a project: ci-test-error.
thiemowmde moved this task from Incoming to In progress on the WMDE-References-FocusArea board.

For reference, here is where I have seen this:
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/87601/console
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/87887/console

gerritbot added a comment.Mar 14 2024, 9:13 AM

Change 1010886 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Skip reuseRefs test until we can debug

https://gerrit.wikimedia.org/r/1010886

gerritbot added a comment.Mar 14 2024, 9:27 AM

Change 1011086 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Try more specific CSS selectors for clicks in browser tests

https://gerrit.wikimedia.org/r/1011086

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 14 2024, 1:00 PM
gerritbot added a comment.Mar 14 2024, 1:33 PM

Change rEOAU1011126a830b had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [Cypress] Increase default timeout

https://gerrit.wikimedia.org/r/1011126

Esanders added a comment.Mar 14 2024, 5:22 PM

To make tests more resilient in general we should:

  • Avoid looking for specific i18n messages
  • Add some CSS classes judiciously to make our selectors less fragile, e.g. by helping us avoid nth child selectors
gerritbot added a comment.Mar 15 2024, 8:06 PM

Change 1011341 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [Cypress] Check toolbar state to wait for VE

https://gerrit.wikimedia.org/r/1011341

gerritbot added a comment.Mar 18 2024, 10:46 AM

Change 1011341 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Cypress] Check toolbar state to wait for VE

https://gerrit.wikimedia.org/r/1011341

gerritbot added a comment.Mar 18 2024, 10:47 AM

Change rEOAU1011126a830b merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Cypress] Increase default timeout

https://gerrit.wikimedia.org/r/1011126

Umherirrender subscribed.EditedMar 18 2024, 7:15 PM

Higher timeout does not help at all patch sets, seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalCssJs/+/1011716
https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php74-docker/88828/console

  1) Re-using refs in Visual Editor
       should display existing references in the Cite re-use dialog:
     CypressError: Timed out retrying after 5050ms: `cy.click()` failed because this element is not visible:

`<span class="oo-ui-tool-title">Re-use</span>`
Umherirrender mentioned this in T358940: GerritBot comments for 7-digit Gerrit changes conflict with Diffusion commit hashes.Mar 18 2024, 7:26 PM
gerritbot added a comment.Mar 19 2024, 9:17 AM

Change 1011086 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Try more specific CSS selectors for clicks in browser tests

https://gerrit.wikimedia.org/r/1011086

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2024, 9:30 AM
ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.24; 2024-03-26); removed MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 19 2024, 10:00 AM
gerritbot added a comment.Mar 19 2024, 1:50 PM

Change 1012679 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Skip tests causing trouble in the wild

https://gerrit.wikimedia.org/r/1012679

gerritbot added a project: Patch-For-Review.Mar 19 2024, 1:51 PM
gerritbot added a comment.Mar 19 2024, 2:19 PM

Change 1012679 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Skip tests causing trouble in the wild

https://gerrit.wikimedia.org/r/1012679

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2024, 2:31 PM
thiemowmde mentioned this in T360361: Flaky Cite cypress tests in ve-cite/veCiteIntegration.cy.js.Mar 20 2024, 10:15 AM
gerritbot added a comment.Mar 20 2024, 11:11 AM

Change 1013023 had a related patch set uploaded (by Mareike Heuer; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] Unskip tests to check for flakyness

https://gerrit.wikimedia.org/r/1013023

gerritbot added a project: Patch-For-Review.Mar 20 2024, 11:11 AM
awight added a comment.Mar 21 2024, 3:13 PM

We seem to have fixed some of the flapping, so I'd recommend merging a revert of the skip next Monday.

gerritbot added a comment.Mar 26 2024, 2:09 PM

Change #1014515 had a related patch set uploaded (by WMDE-Fisch; author: Mareike Heuer):

[mediawiki/extensions/Cite@master] [DNM] Run flaky tests 50 times

https://gerrit.wikimedia.org/r/1014515

gerritbot added a comment.Mar 26 2024, 3:08 PM

Change #1014529 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] Wait for VE to load

https://gerrit.wikimedia.org/r/1014529

gerritbot added a comment.Mar 26 2024, 7:31 PM

Change #1014586 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] [Cypress] Retry toolbar clicks to open submenu

https://gerrit.wikimedia.org/r/1014586

WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-03-13 board.Mar 26 2024, 7:38 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2024-03-27.Mar 27 2024, 1:22 PM
WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-03-27 board.
gerritbot added a comment.Mar 27 2024, 4:38 PM

Change #1014529 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Cypress] Wait for VE to load

https://gerrit.wikimedia.org/r/1014529

gerritbot added a comment.Mar 27 2024, 4:43 PM

Change #1014586 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Cypress] Retry toolbar clicks to open submenu

https://gerrit.wikimedia.org/r/1014586

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.25; 2024-04-02); removed MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).Mar 27 2024, 5:00 PM
gerritbot added a comment.Mar 28 2024, 9:39 AM

Change #1013023 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] [Cypress] Unskip tests

https://gerrit.wikimedia.org/r/1013023

MareikeHeuerWMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2024-03-13 board.Mar 28 2024, 9:47 AM
WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2024-03-27 board.Mar 28 2024, 9:49 AM
Umherirrender unsubscribed.Apr 4 2024, 6:13 PM
WMDE-Fisch closed this task as Resolved.Apr 12 2024, 9:12 AM
WMDE-Fisch claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL