Page MenuHomePhabricator

Replace <a> and <image> in message uploaded-href-attribute-svg with a masked
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Core message uploaded-href-attribute-svg contains a "<a>" and "<image>"

What happens?:

Jenkins job mediawiki-i18n-check-docker/174193/console throws an warning: "'HTML detected. Manual review required'". Example.

What should have happened instead?:

To avoid a manual review I suggest to mask <a> and <image>

Event Timeline

Change 1011099 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/core@master] Replace "<a>" with entities in a message

https://gerrit.wikimedia.org/r/1011099

Change 1011099 merged by jenkins-bot:

[mediawiki/core@master] Replace "<a>" with entities in a message

https://gerrit.wikimedia.org/r/1011099

Raymond renamed this task from Replace <a> in message uploaded-href-attribute-svg with a masked to Replace <a> and <image> in message uploaded-href-attribute-svg with a masked .Mar 15 2024, 7:51 AM
Raymond updated the task description. (Show Details)

I am sorry, but I have not seen that this message contains <image> too, see https://integration.wikimedia.org/ci/job/mediawiki-i18n-check-docker/174270/console

Change 1011380 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/core@master] Replace <> with entities on a mentioned SVG tag

https://gerrit.wikimedia.org/r/1011380

Change 1011380 merged by jenkins-bot:

[mediawiki/core@master] Replace <> with entities on a mentioned SVG tag

https://gerrit.wikimedia.org/r/1011380

Change 1011403 had a related patch set uploaded (by Amire80; author: Amire80):

[mediawiki/core@master] Fix HTML entity

https://gerrit.wikimedia.org/r/1011403

Change 1011403 merged by jenkins-bot:

[mediawiki/core@master] Fix HTML entity

https://gerrit.wikimedia.org/r/1011403