Page MenuHomePhabricator
Create Task
Maniphest T360601

🐙 Implement “data type aware” snak deserializer
Closed, ResolvedPublic
Actions

Description

  • consider optimizing this right away so that it only looks up the data type if necessary. How to tell whether it's necessary: look up all data types corresponding to the given value type. The lookup is necessary only if one of the data types register a custom value-parser.
  • Probably don’t want to extend the existing SnakDeserializer (like the PoC does)

Details

SubjectRepoBranchLines +/-
Return UnDeserializableValue if dt lookup failsmediawiki/extensions/Wikibasemaster+60 -30
Optimize DataTypeAwareSnakDeserializermediawiki/extensions/Wikibasemaster+42 -4
Implement DataTypeAwareSnakDeserializermediawiki/extensions/Wikibasemaster+72 -17
Copy SnakDeserializer -> DataTypeAwareSnakDeserializermediawiki/extensions/Wikibasemaster+385 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dima_Koushha_WMDE created this task.Mar 21 2024, 9:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2024, 9:16 AM
Ifrahkhanyaree_WMDE moved this task from Sprint 16 to Sprint 17 on the Wikibase Product Platform Team WPP board.Apr 2 2024, 10:00 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 17); removed Wikibase Product Platform Team WPP (Sprint 16).
Jakob_WMDE claimed this task.Apr 3 2024, 2:58 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 17) board.
gerritbot added a comment.Apr 4 2024, 10:53 AM

Change #1017040 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Copy SnakDeserializer -> DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017040

gerritbot added a project: Patch-For-Review.Apr 4 2024, 10:53 AM
Lucas_Werkmeister_WMDE mentioned this in T350136: Investigate "PseudoEntityId-interface" approach for extending Wikibase in a type-safe way.Apr 4 2024, 12:41 PM
gerritbot added a comment.Apr 4 2024, 2:21 PM

Change #1017087 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Implement DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017087

gerritbot added a comment.Apr 4 2024, 3:26 PM

Change #1017097 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Optimize DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017097

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 17) board.Apr 4 2024, 3:38 PM
gerritbot added a comment.Wed, Apr 10, 1:33 PM

Change #1017040 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Copy SnakDeserializer -> DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017040

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Wed, Apr 10, 2:00 PM
gerritbot added a comment.Wed, Apr 10, 2:22 PM

Change #1018726 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Return UnDeserializableValue if dt lookup fails

https://gerrit.wikimedia.org/r/1018726

gerritbot added a comment.Wed, Apr 10, 2:26 PM

Change #1017087 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Implement DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017087

gerritbot added a comment.Wed, Apr 10, 4:26 PM

Change #1017097 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Optimize DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017097

gerritbot added a comment.Fri, Apr 12, 1:13 PM

Change #1018726 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Return UnDeserializableValue if dt lookup fails

https://gerrit.wikimedia.org/r/1018726

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 17) board.Mon, Apr 15, 9:06 AM
Dima_Koushha_WMDE removed a project: Patch-For-Review.Mon, Apr 15, 9:42 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Apr 16, 10:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL