Page MenuHomePhabricator
Create Task
Maniphest T360603

🐙 Plug in the new deserializer everywhere (client and repo)
Closed, ResolvedPublic
Actions

Description

  • ! only do this once if the new deserializer is optimized. We don’t want to ship the non-optimized version to production without testing it.
  • Remove the old SnakDeserializer?

Details

SubjectRepoBranchLines +/-
Revert "Temporarily weaken SnakDeserializer type hint"mediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Remove the old SnakDeserializermediawiki/extensions/Wikibasemaster+187 -597
Unskip tests involving DeserializerFactorymediawiki/extensions/WikibaseLexememaster+12 -5
Wire up DataTypeAwareSnakDeserializermediawiki/extensions/Wikibasemaster+206 -50
Temporarily skip tests involving DeserializerFactorymediawiki/extensions/WikibaseLexememaster+2 -0
Temporarily weaken SnakDeserializer type hintmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Don't configure parser-factory-callbackmediawiki/extensions/Mathmaster+0 -7
Don't configure parser-factory-callbackmediawiki/extensions/Scoremaster+0 -7
Don't configure parser-factory-callbackmediawiki/extensions/MathSearchmaster+0 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dima_Koushha_WMDE created this task.Mar 21 2024, 9:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2024, 9:19 AM
Ifrahkhanyaree_WMDE moved this task from Sprint 16 to Sprint 17 on the Wikibase Product Platform Team WPP board.Apr 2 2024, 10:00 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 17); removed Wikibase Product Platform Team WPP (Sprint 16).
Jakob_WMDE claimed this task.Apr 5 2024, 1:53 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 17) board.
gerritbot added a comment.Apr 8 2024, 3:41 PM

Change #1017878 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Wire up DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017878

gerritbot added a project: Patch-For-Review.Apr 8 2024, 3:41 PM
gerritbot added a comment.Tue, Apr 9, 1:18 PM

Change #1018269 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Temporarily skip tests involving DeserializerFactory

https://gerrit.wikimedia.org/r/1018269

gerritbot added a comment.Tue, Apr 9, 1:22 PM

Change #1018271 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseQualityConstraints@master] Temporarily weaken SnakDeserializer type hint

https://gerrit.wikimedia.org/r/1018271

gerritbot added a comment.Tue, Apr 9, 5:14 PM

Change #1018319 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Math@master] Don't configure parser-factory-callback

https://gerrit.wikimedia.org/r/1018319

gerritbot added a comment.Tue, Apr 9, 5:19 PM

Change #1018321 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Score@master] Don't configure parser-factory-callback

https://gerrit.wikimedia.org/r/1018321

Physikerwelt subscribed.Wed, Apr 10, 4:31 PM

Maybe this also applies to extension MathSearch?

gerritbot added a comment.Wed, Apr 10, 8:29 PM

Change #1018784 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/MathSearch@master] Don't configure parser-factory-callback

https://gerrit.wikimedia.org/r/1018784

Jakob_WMDE added a comment.Wed, Apr 10, 8:33 PM
In T360603#9704577, @Physikerwelt wrote:

Maybe this also applies to extension MathSearch?

Yup, thanks!

gerritbot added a comment.Thu, Apr 11, 5:46 AM

Change #1018784 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Don't configure parser-factory-callback

https://gerrit.wikimedia.org/r/1018784

Jakob_WMDE mentioned this in rEMAS839d848ce3d8: Don't configure parser-factory-callback.Thu, Apr 11, 6:15 AM
gerritbot added a comment.Fri, Apr 12, 9:45 AM

Change #1018321 merged by jenkins-bot:

[mediawiki/extensions/Score@master] Don't configure parser-factory-callback

https://gerrit.wikimedia.org/r/1018321

gerritbot added a comment.Fri, Apr 12, 9:47 AM

Change #1018319 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Don't configure parser-factory-callback

https://gerrit.wikimedia.org/r/1018319

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Fri, Apr 12, 10:00 AM
gerritbot added a comment.Mon, Apr 15, 7:55 AM

Change #1019670 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Remove the old SnakDeserializer

https://gerrit.wikimedia.org/r/1019670

gerritbot added a comment.Mon, Apr 15, 8:08 AM

Change #1019672 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseQualityConstraints@master] Revert "Temporarily weaken SnakDeserializer type hint"

https://gerrit.wikimedia.org/r/1019672

gerritbot added a comment.Mon, Apr 15, 11:17 AM

Change #1019722 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Unskip tests involving DeserializerFactory

https://gerrit.wikimedia.org/r/1019722

Physikerwelt unsubscribed.Mon, Apr 15, 3:47 PM

Removing myself as the Math(Search)? part is done

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 17) board.Tue, Apr 16, 4:34 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 18); removed Wikibase Product Platform Team WPP (Sprint 17).Tue, Apr 16, 10:20 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Peer Review on the Wikibase Product Platform Team WPP (Sprint 18) board.
gerritbot added a comment.Wed, Apr 17, 1:57 PM

Change #1018271 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Temporarily weaken SnakDeserializer type hint

https://gerrit.wikimedia.org/r/1018271

gerritbot added a comment.Wed, Apr 17, 1:57 PM

Change #1018269 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Temporarily skip tests involving DeserializerFactory

https://gerrit.wikimedia.org/r/1018269

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.2; 2024-04-23); removed MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Wed, Apr 17, 2:00 PM
gerritbot added a comment.Wed, Apr 17, 2:35 PM

Change #1017878 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Wire up DataTypeAwareSnakDeserializer

https://gerrit.wikimedia.org/r/1017878

gerritbot added a comment.Thu, Apr 18, 8:26 AM

Change #1019722 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Unskip tests involving DeserializerFactory

https://gerrit.wikimedia.org/r/1019722

gerritbot added a comment.Thu, Apr 18, 9:23 AM

Change #1019670 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove the old SnakDeserializer

https://gerrit.wikimedia.org/r/1019670

gerritbot added a comment.Thu, Apr 18, 10:35 AM

Change #1019672 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Revert "Temporarily weaken SnakDeserializer type hint"

https://gerrit.wikimedia.org/r/1019672

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 18) board.Fri, Apr 19, 9:03 AM
Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 26, 6:08 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Apr 30, 10:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL