Page MenuHomePhabricator

Wire EditAttemptStepEvent for undo and rollback actions
Closed, ResolvedPublic

Description

The current diff screen only logs the undo/rollback events for Patroller Tasks.

This task is to add EditAttemptStepEvent for undo and rollback actions.

This ticket will introduce the new editor_interface: undo and rollback
This will use the other editor_interface to log undo/rollback action. If we want a different editor_interface, then we will need to update the schema.

action=init
When entering the diff screen

action=saveIntent
When clicking on the "Undo" button

action=saveAttempt
When the undo/rollback dialog is shown

action=saveSuccess
Undo/rollback action executed successfully

action=saveFailure
Undo/rollback action failed


@SNowick_WMF Please let me know if you want to use other editor_interface.

Event Timeline

This looks good - we can use other or wikitext for editor_interface where appropriate.

Hi @ABorbaWMF

Please use the dev APK to test
https://drive.google.com/file/d/1cS56kudcBYTK2TyO2UmOftosQpKb400o/view?usp=sharing

Live streaming
https://stream-beta.wmflabs.org/v2/ui/#/?streams=eventlogging_EditAttemptStep

Please make sure to set the "Event platform batch size" to 1
Settings -> Developer settings -> inside "Logging" section -> Event platform batch size